Uh oh!
There was an error while loading. Please reload this page.
[iot] fix: use fixtures for resource setup/teardown - #3428
Merged
Conversation
tmatsuo
commented
Apr 19, 2020
ContributorAuthor
The topic name is very likely conflicting. |
tmatsuo
commented
Apr 19, 2020
ContributorAuthor
Ha! The image test is failing for the same reason. |
* share the fixtures within two tests * correct dependencies between fixtures * use threading for cordinating between background and foreground threads.
tmatsuo
commented
Apr 21, 2020
ContributorAuthor
Since we got approval from the product owner, I'm going to merge this with the admin power. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes#2861
fixes#3323
I also think:
fixes#2859
fixes#2860