Skip to content

Adding tests for managed_vms/analytics. Fixes #180 - #350

Merged
theacodes merged 1 commit into
masterfrom
analytics-tests
May 16, 2016
Merged

Adding tests for managed_vms/analytics. Fixes #180#350
theacodes merged 1 commit into
masterfrom
analytics-tests

Conversation

@theacodes

Copy link
Copy Markdown
Contributor

No description provided.

@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label May 16, 2016
Comment threadmanaged_vms/analytics/main_test.py Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this has something to do with monkeypathcing>

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yar, follows the same pattern at managed_vms/mailjet/main_test.py. Basically you can't import main until the env vars are patched. This is actually a common pattern in test fixtures - hide how the actual object constructed from the tests.

Change-Id: I8f049927e81f6786d1221a867539b64a2e5245db
@waprin

Copy link
Copy Markdown
Contributor

lgtm

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yesThis human has signed the Contributor License Agreement.testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@theacodes@waprin@googlebot