Skip to content

chore: remove BigQuery cloud-client samples - #4179

Merged
busunkim96 merged 8 commits into
GoogleCloudPlatform:masterfrom
plamut:remove-bigquery-samples
Jul 31, 2020
Merged

chore: remove BigQuery cloud-client samples#4179
busunkim96 merged 8 commits into
GoogleCloudPlatform:masterfrom
plamut:remove-bigquery-samples

Conversation

@plamut

@plamutplamut commented Jun 26, 2020

Copy link
Copy Markdown
Contributor

Do not merge until googleapis/python-bigquery#148, as well as an internal PR that will redirect the BigQuery docs to point to the new samples location (TODO: somebody please open that PR).

@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 26, 2020
@tmatsuotmatsuo added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jul 6, 2020
@plamut
plamutforce-pushed the remove-bigquery-samples branch from 216b859 to 86d47b9CompareJuly 23, 2020 07:31
@plamut

plamut commented Jul 23, 2020

Copy link
Copy Markdown
ContributorAuthor

Samples have been moved to the BigQuery repo: googleapis/python-bigquery#174

We need to point the docs at cloud.google.com to the new location before merging this.

@plamut
plamut marked this pull request as ready for review July 23, 2020 07:33
@plamut
plamut requested review from a team and shollyman as code ownersJuly 23, 2020 07:33
@shollyman

shollyman commented Jul 23, 2020

Copy link
Copy Markdown
Contributor

I'll work on doing the docsite internal change today to re-point all the embeds.

@shollyman

shollyman commented Jul 23, 2020

Copy link
Copy Markdown
Contributor

tracking internally as 162000215

shollyman
shollyman approved these changes Jul 23, 2020
View reviewed changes

@shollymanshollyman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, docs should be repointed.

tmatsuo
tmatsuo suggested changes Jul 23, 2020
View reviewed changes
Comment threadbigquery/cloud-client/README.rst
@tmatsuotmatsuo removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jul 23, 2020
@busunkim96
busunkim96 requested a review from tmatsuoJuly 24, 2020 00:37
@busunkim96busunkim96 added kokoro:force-run Add this label to force Kokoro to re-run the tests. automerge Merge the pull request once unit tests and other checks pass. labels Jul 25, 2020
@kokoro-teamkokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 25, 2020
@leahecoleleahecole added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 28, 2020
@kokoro-teamkokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 28, 2020
@plamut

plamut commented Jul 31, 2020•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

What's the status of this, can somebody please re-run the tests (the status appears stalled)?
Thanks!

@gcf-merge-on-green

gcf-merge-on-greenBot commented Jul 31, 2020

Copy link
Copy Markdown
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, or one of your required reviews was not approved. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-greengcf-merge-on-greenBot removed the automerge Merge the pull request once unit tests and other checks pass. label Jul 31, 2020
@busunkim96busunkim96 added kokoro:force-run Add this label to force Kokoro to re-run the tests. automerge Merge the pull request once unit tests and other checks pass. labels Jul 31, 2020
@kokoro-teamkokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 31, 2020
@busunkim96
busunkim96 merged commit f0a8ffa into GoogleCloudPlatform:masterJul 31, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shollymanshollymanshollyman approved these changes
@tmatsuotmatsuoAwaiting requested review from tmatsuo
+1 more reviewer
@busunkim96busunkim96busunkim96 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@tmatsuotmatsuo

Labels

automergeMerge the pull request once unit tests and other checks pass.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@plamut@shollyman@tmatsuo@busunkim96@googlebot@leahecole@kokoro-team