Skip to content

fix: increase batch translation timeout to 300 - #4357

Merged
tmatsuo merged 2 commits into
masterfrom
translation-timeout
Jul 22, 2020
Merged

fix: increase batch translation timeout to 300#4357
tmatsuo merged 2 commits into
masterfrom
translation-timeout

Conversation

@telpirion

@telpiriontelpirion commented Jul 22, 2020

Copy link
Copy Markdown
Contributor

This PR increases the timeout for the translate_v3_batch_translate_text_test from 240 to 300.

Fixes#4221
Fixes#4239

@telpirion
telpirion requested review from a team and sirtorry as code ownersJuly 22, 2020 21:38
@google-clagoogle-claBot added the cla: yes This human has signed the Contributor License Agreement. label Jul 22, 2020
@telpirion
telpirion requested a review from tmatsuoJuly 22, 2020 21:38

@tmatsuotmatsuo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is another variant. I thought the name was batch_translate_test_with_glossaries or sth.

Does it make sense to bump there as well?

@telpirion

Copy link
Copy Markdown
ContributorAuthor

Good call! Yes, let's bump the timeout on batch translate w/ glossary too.

@tmatsuo
tmatsuo merged commit c6fc919 into masterJul 22, 2020
@tmatsuo
tmatsuo deleted the translation-timeout branch July 22, 2020 22:59
@telpirion
telpirion requested a review from leahecoleJuly 23, 2020 15:36
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

3 participants

@telpirion@tmatsuo@leahecole