Skip to content

chore: fixes flaky test - #4815

Merged
danoscarmike merged 3 commits into
masterfrom
flaky-vid
Oct 6, 2020
Merged

chore: fixes flaky test#4815
danoscarmike merged 3 commits into
masterfrom
flaky-vid

Conversation

@danoscarmike

Copy link
Copy Markdown
Contributor

Fixes#4794

@danoscarmike
danoscarmike requested review from a team and sirtorry as code ownersOctober 6, 2020 18:00
@google-clagoogle-claBot added the cla: yes This human has signed the Contributor License Agreement. label Oct 6, 2020

@leahecoleleahecole left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YES. Thank you! I was just looking at test failures caused by this.

Fixes#4793
Removes assertion which the backend inconsistently satifies.
@danoscarmike
danoscarmike merged commit 1264ce6 into masterOct 6, 2020
@danoscarmike
danoscarmike deleted the flaky-vid branch October 6, 2020 18:54
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

video.cloud-client.analyze.video_detect_faces_beta_test: test_detect_faces failed

3 participants

@danoscarmike@tmatsuo@leahecole