Skip to content

Revert & fix "Revert "Lint session should check all changed files. (#… - #621

Merged
theacodes merged 2 commits into
masterfrom
lint
Oct 27, 2016
Merged

Revert & fix "Revert "Lint session should check all changed files. (#…#621
theacodes merged 2 commits into
masterfrom
lint

Conversation

@jerjou

Copy link
Copy Markdown
Contributor

…619)""

This reverts commit ae8dccb.

@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 27, 2016
@jerjou

Copy link
Copy Markdown
ContributorAuthor

(tested manually by running nox -s lint . in a virtualenv)

@jerjoujerjou added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 27, 2016
@jerjou

Copy link
Copy Markdown
ContributorAuthor

(actually - hold off - I realize my test was a little suspicious.. investigating..)

@theacodes

Copy link
Copy Markdown
Contributor

I don't think you should run nox -s lint ., nox is supposed to run a separate lint for each sample because of local import names.

@jerjoujerjou removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 27, 2016
@jerjou

Copy link
Copy Markdown
ContributorAuthor

Okay - fixed. Also fixed a bunch of lint errors. PTAL.

@theacodes
theacodes merged commit aac0e02 into masterOct 27, 2016
@theacodes
theacodes deleted the lint branch October 27, 2016 19:15
Linchin pushed a commit that referenced this pull request Aug 18, 2025
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
chalmerlowe pushed a commit that referenced this pull request Feb 19, 2026
- [ ] Regenerate this pull request now.
PiperOrigin-RevId: 472561635
Source-Link: googleapis/googleapis@332ecf5
Source-Link: https://github.com/googleapis/googleapis-gen/commit/4313d682880fd9d7247291164d4e9d3d5bd9f177
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNDMxM2Q2ODI4ODBmZDlkNzI0NzI5MTE2NGQ0ZTlkM2Q1YmQ5ZjE3NyJ9
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@jerjou@theacodes@googlebot