Skip to content

chore(dataflow): update conftest, make publisher subprocess a daemon - #6475

Merged
leahecole merged 11 commits into
GoogleCloudPlatform:masterfrom
davidcavazos:dataflow-fix-flaky-tests
Jul 30, 2021
Merged

chore(dataflow): update conftest, make publisher subprocess a daemon#6475
leahecole merged 11 commits into
GoogleCloudPlatform:masterfrom
davidcavazos:dataflow-fix-flaky-tests

Conversation

@davidcavazos

@davidcavazosdavidcavazos commented Jul 26, 2021

Copy link
Copy Markdown

Description

Fixes#6445, #6094

  • Update conftest to use the newer version in the GPU samples
  • Make the publisher subprocess a daemon so the main process doesn't wait indefinitely
  • Other small overall improvements in the conftest

ℹ️ The large diff of the conftest is because I'm replacing the parent conftest with the more updated one from the gpu-examples. I deliberately separated the conftest updates so I could fix these issues in a separate PR without triggering the flaky tests.

Checklist

@davidcavazos
davidcavazos requested a review from a team as a code ownerJuly 26, 2021 18:59
@product-auto-labelproduct-auto-labelBot added api: dataflow Issues related to the Dataflow API. samples Issues that are directly related to samples. labels Jul 26, 2021
@google-clagoogle-claBot added the cla: yes This human has signed the Contributor License Agreement. label Jul 26, 2021
@davidcavazos
davidcavazosforce-pushed the dataflow-fix-flaky-tests branch from af41d86 to 73073fbCompareJuly 26, 2021 19:05
@davidcavazosdavidcavazos added the blunderbuss: assign Instruct blunderbuss to assign someone label Jul 27, 2021
@blunderbuss-gcfblunderbuss-gcfBot removed the blunderbuss: assign Instruct blunderbuss to assign someone label Jul 27, 2021
Comment threaddataflow/conftest.py
@partheaparthea changed the title dataflow: update conftest, make publisher subprocess a daemonchore(dataflow): update conftest, make publisher subprocess a daemonJul 30, 2021
@leahecole
leahecole merged commit 6bba089 into GoogleCloudPlatform:masterJul 30, 2021
@davidcavazos
davidcavazos deleted the dataflow-fix-flaky-tests branch July 30, 2021 18:59
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: dataflowIssues related to the Dataflow API.cla: yesThis human has signed the Contributor License Agreement.samplesIssues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Address Dataflow pytest fixtures issues

3 participants

@davidcavazos@leahecole@busunkim96