Skip to content

fix: update samples for pap, unspecified -> inherited - #6757

Merged
unforced merged 17 commits into
GoogleCloudPlatform:masterfrom
unforced:pap_changes
Oct 4, 2021
Merged

fix: update samples for pap, unspecified -> inherited#6757
unforced merged 17 commits into
GoogleCloudPlatform:masterfrom
unforced:pap_changes

Conversation

@unforced

Copy link
Copy Markdown
Contributor

Updates samples in accord with public access prevention changes, changing unspecified to inherited.

@unforced
unforced requested review from a team as code ownersSeptember 28, 2021 19:43
@product-auto-labelproduct-auto-labelBot added the samples Issues that are directly related to samples. label Sep 28, 2021
@snippet-bot

snippet-botBot commented Sep 28, 2021

Copy link
Copy Markdown

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@google-clagoogle-claBot added the cla: yes This human has signed the Contributor License Agreement. label Sep 28, 2021
@cojencocojenco added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Sep 29, 2021
@cojenco

Copy link
Copy Markdown
Contributor

@Breathtender Thanks for working on this! Instead of replacing the existing sample storage_set_public_access_prevention_unspecified.py, we want to create a new samplestorage_set_public_access_prevention_inherited.py

Please refer to #6751

@shaffeeullah

Copy link
Copy Markdown
Contributor

@Breathtender Thanks for working on this! Instead of replacing the existing sample storage_set_public_access_prevention_unspecified.py, we want to create a new samplestorage_set_public_access_prevention_inherited.py

Please refer to #6751

+1, thanks cathy! the unspecified sample test might have to be deleted to get all the tests passing. if so, that's okay. however, please keep the sample there for now, as it is linked from the public documentation.

thanks for working on this @Breathtender !

@unforced

Copy link
Copy Markdown
ContributorAuthor

This should be all ready, just waiting for googleapis/python-storage#603 to be released so that the tests can pass.

@nicainnicain left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small change requested

Comment threadstorage/cloud-client/storage_set_public_access_prevention_inherited.py Outdated
Aaron Gabriel Neyerand others added 2 commits September 29, 2021 16:15
@unforcedunforced added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 1, 2021
@kokoro-teamkokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 1, 2021
@unforced
unforced requested review from cojenco and nicainOctober 1, 2021 21:17
@unforcedunforced removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 1, 2021

@nicainnicain left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nicain

Copy link
Copy Markdown
Contributor

@leahecole python3.10 build is failing for the PR, with nox > Session py-3.10 failed: Python interpreter 3.10 not found.. Can you recommend a fix? 3.10 goes live Monday, correct?

@nicainnicain left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cojencocojenco left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@unforced
unforced merged commit e90c44a into GoogleCloudPlatform:masterOct 4, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yesThis human has signed the Contributor License Agreement.samplesIssues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@unforced@cojenco@shaffeeullah@nicain@kokoro-team@dandhlee