Skip to content

Add auth_token support for the grpc client. - #681

Merged
theacodes merged 3 commits into
GoogleCloudPlatform:masterfrom
qiwzhang:ppp
Nov 29, 2016
Merged

Add auth_token support for the grpc client.#681
theacodes merged 3 commits into
GoogleCloudPlatform:masterfrom
qiwzhang:ppp

Conversation

@qiwzhang

@qiwzhangqiwzhang commented Nov 23, 2016

Copy link
Copy Markdown
Contributor

No description provided.

@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 23, 2016
@qiwzhang

qiwzhang commented Nov 23, 2016

Copy link
Copy Markdown
ContributorAuthor

@jeffmendoza could you help to review it?

@jeffmendoza

jeffmendoza commented Nov 23, 2016

Copy link
Copy Markdown
Contributor

For python code, I'll defer to @jonparrott or @waprin

waprin
waprin reviewed Nov 24, 2016
View reviewed changes
Comment threadendpoints/bookstore-grpc/bookstore_client.py
if api_key:
metadata.append(('x-api-key', api_key))
if auth_token:
metadata.append(('authorization', 'Bearer ' + auth_token))

@waprinwaprinNov 24, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before if there was no API key, metadata was None, now it will be an empty list. I have no idea if this matters or not, but thought I would check

@qiwzhangqiwzhangNov 28, 2016

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it, passing [] works. It should be the same as passing None.

@waprin

waprin commented Nov 24, 2016

Copy link
Copy Markdown
Contributor

Code LGTM with one question, lint is failing on Travis. I am concerned that this directory has 0% test coverage?

@theacodes

theacodes commented Nov 28, 2016

Copy link
Copy Markdown
Contributor

Definitely fix the lint errors on Travis.

@qiwzhang

qiwzhang commented Nov 29, 2016

Copy link
Copy Markdown
ContributorAuthor

Lint errors have been fixed. Test will be added by separate PR.

@qiwzhang

qiwzhang commented Nov 29, 2016

Copy link
Copy Markdown
ContributorAuthor

lint errors have been fixed. @jonparrott or @waprin, could you help to review it.? thanks.

@theacodes
theacodes merged commit 0b83984 into GoogleCloudPlatform:masterNov 29, 2016
chalmerlowe pushed a commit that referenced this pull request Apr 7, 2026
@renovate-bot
chore(deps): update dependency pandas to v1.3.5 (#681)
a08e532
[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)
This PR contains the following updates:
| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [pandas](https://pandas.pydata.org) ([source](https://togithub.com/pandas-dev/pandas)) | `==1.1.5` -> `==1.3.5` | [![age](https://badges.renovateapi.com/packages/pypi/pandas/1.3.5/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/pypi/pandas/1.3.5/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/pypi/pandas/1.3.5/compatibility-slim/1.1.5)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/pypi/pandas/1.3.5/confidence-slim/1.1.5)](https://docs.renovatebot.com/merge-confidence/) |
| [pandas](https://pandas.pydata.org) ([source](https://togithub.com/pandas-dev/pandas)) | `==1.3.4` -> `==1.3.5` | [![age](https://badges.renovateapi.com/packages/pypi/pandas/1.3.5/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/pypi/pandas/1.3.5/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/pypi/pandas/1.3.5/compatibility-slim/1.3.4)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/pypi/pandas/1.3.5/confidence-slim/1.3.4)](https://docs.renovatebot.com/merge-confidence/) |
---
### Release Notes
<details>
<summary>pandas-dev/pandas</summary>
### [`v1.3.5`](https://togithub.com/pandas-dev/pandas/releases/v1.3.5)
[Compare Source](https://togithub.com/pandas-dev/pandas/compare/v1.3.4...v1.3.5)
This is a patch release in the 1.3.x series and includes some regression fixes. We recommend that all users upgrade to this version.
See the [full whatsnew](https://pandas.pydata.org/pandas-docs/version/1.3.5/whatsnew/v1.3.5.html) for a list of all the changes.
The release will be available on the defaults and conda-forge channels:
conda install pandas
Or via PyPI:
python3 -m pip install --upgrade pandas
Please report any issues with the release on the [pandas issue tracker](https://togithub.com/pandas-dev/pandas/issues).
### [`v1.3.4`](https://togithub.com/pandas-dev/pandas/releases/v1.3.4)
[Compare Source](https://togithub.com/pandas-dev/pandas/compare/v1.3.3...v1.3.4)
This is a patch release in the 1.3.x series and includes some regression fixes and bug fixes. We recommend that all users upgrade to this version.
See the [full whatsnew](https://pandas.pydata.org/pandas-docs/version/1.3.4/whatsnew/v1.3.4.html) for a list of all the changes.
The release will be available on the defaults and conda-forge channels:
conda install pandas
Or via PyPI:
python3 -m pip install --upgrade pandas
Please report any issues with the release on the [pandas issue tracker](https://togithub.com/pandas-dev/pandas/issues).
### [`v1.3.3`](https://togithub.com/pandas-dev/pandas/releases/v1.3.3)
[Compare Source](https://togithub.com/pandas-dev/pandas/compare/v1.3.2...v1.3.3)
This is a patch release in the 1.3.x series and includes some regression fixes and bug fixes. We recommend that all users upgrade to this version.
See the [full whatsnew](https://pandas.pydata.org/pandas-docs/version/1.3.3/whatsnew/v1.3.3.html) for a list of all the changes.
The release will be available on the defaults and conda-forge channels:
conda install pandas
Or via PyPI:
python3 -m pip install --upgrade pandas
Please report any issues with the release on the [pandas issue tracker](https://togithub.com/pandas-dev/pandas/issues).
### [`v1.3.2`](https://togithub.com/pandas-dev/pandas/releases/v1.3.2)
[Compare Source](https://togithub.com/pandas-dev/pandas/compare/v1.3.1...v1.3.2)
This is a patch release in the 1.3.x series and includes some regression fixes and bug fixes. We recommend that all users upgrade to this version.
See the [full whatsnew](https://pandas.pydata.org/pandas-docs/version/1.3.2/whatsnew/v1.3.2.html) for a list of all the changes.
The release will be available on the defaults and conda-forge channels:
conda install pandas
Or via PyPI:
python3 -m pip install --upgrade pandas
Please report any issues with the release on the [pandas issue tracker](https://togithub.com/pandas-dev/pandas/issues).
### [`v1.3.1`](https://togithub.com/pandas-dev/pandas/releases/v1.3.1)
[Compare Source](https://togithub.com/pandas-dev/pandas/compare/v1.3.0...v1.3.1)
This is the first patch release in the 1.3.x series and includes some regression fixes and bug fixes. We recommend that all users upgrade to this version.
See the [full whatsnew](https://pandas.pydata.org/pandas-docs/version/1.3.1/whatsnew/v1.3.1.html) for a list of all the changes.
The release will be available on the defaults and conda-forge channels:
conda install pandas
Or via PyPI:
python3 -m pip install --upgrade pandas
Please report any issues with the release on the [pandas issue tracker](https://togithub.com/pandas-dev/pandas/issues).
### [`v1.3.0`](https://togithub.com/pandas-dev/pandas/releases/v1.3.0)
[Compare Source](https://togithub.com/pandas-dev/pandas/compare/v1.2.5...v1.3.0)
This release includes some new features, bug fixes, and performance improvements. We recommend that all users upgrade to this version.
See the [full whatsnew](https://pandas.pydata.org/pandas-docs/version/1.3.0/whatsnew/v1.3.0.html) for a list of all the changes.
The release will be available on the defaults and conda-forge channels:
conda install -c conda-forge pandas
Or via PyPI:
python3 -m pip install --upgrade pandas
Please report any issues with the release on the [pandas issue tracker](https://togithub.com/pandas-dev/pandas/issues).
### [`v1.2.5`](https://togithub.com/pandas-dev/pandas/releases/v1.2.5)
[Compare Source](https://togithub.com/pandas-dev/pandas/compare/v1.2.4...v1.2.5)
This is a patch release in the 1.2.x series and includes some regression fixes. We recommend that all users upgrade to this version.
See the [full whatsnew](https://pandas.pydata.org/pandas-docs/version/1.2.5/whatsnew/v1.2.5.html) for a list of all the changes.
The release will be available on the defaults and conda-forge channels:
conda install pandas
Or via PyPI:
python3 -m pip install --upgrade pandas
Please report any issues with the release on the [pandas issue tracker](https://togithub.com/pandas-dev/pandas/issues).
### [`v1.2.4`](https://togithub.com/pandas-dev/pandas/releases/v1.2.4)
[Compare Source](https://togithub.com/pandas-dev/pandas/compare/v1.2.3...v1.2.4)
This is a patch release in the 1.2.x series and includes some regression fixes. We recommend that all users upgrade to this version.
See the [full whatsnew](https://pandas.pydata.org/pandas-docs/version/1.2.4/whatsnew/v1.2.4.html) for a list of all the changes.
The release will be available on the defaults and conda-forge channels:
conda install pandas
Or via PyPI:
python3 -m pip install --upgrade pandas
Please report any issues with the release on the [pandas issue tracker](https://togithub.com/pandas-dev/pandas/issues).
### [`v1.2.3`](https://togithub.com/pandas-dev/pandas/releases/v1.2.3)
[Compare Source](https://togithub.com/pandas-dev/pandas/compare/v1.2.2...v1.2.3)
This is a patch release in the 1.2.x series and includes some regression fixes. We recommend that all users upgrade to this version.
See the [full whatsnew](https://pandas.pydata.org/pandas-docs/version/1.2.3/whatsnew/v1.2.3.html) for a list of all the changes.
The release will be available on the defaults and conda-forge channels:
conda install pandas
Or via PyPI:
python3 -m pip install --upgrade pandas
Please report any issues with the release on the [pandas issue tracker](https://togithub.com/pandas-dev/pandas/issues).
### [`v1.2.2`](https://togithub.com/pandas-dev/pandas/releases/v1.2.2)
[Compare Source](https://togithub.com/pandas-dev/pandas/compare/v1.2.1...v1.2.2)
This is a patch release in the 1.2.x series and includes some regression fixes
and bug fixes. We recommend that all users upgrade to this version.
See the [full whatsnew](https://pandas.pydata.org/pandas-docs/version/1.2.2/whatsnew/v1.2.2.html) for a list of all the changes.
The release will be available on the defaults and conda-forge channels:
conda install pandas
Or via PyPI:
python3 -m pip install --upgrade pandas
Please report any issues with the release on the [pandas issue tracker](https://togithub.com/pandas-dev/pandas/issues).
### [`v1.2.1`](https://togithub.com/pandas-dev/pandas/releases/v1.2.1)
[Compare Source](https://togithub.com/pandas-dev/pandas/compare/v1.2.0...v1.2.1)
This is the first patch release in the 1.2.x series and includes some regression fixes
and bug fixes. We recommend that all users upgrade to this version.
See the [full whatsnew](https://pandas.pydata.org/pandas-docs/version/1.2.1/whatsnew/v1.2.1.html) for a list of all the changes.
The release will be available on the defaults and conda-forge channels:
conda install pandas
Or via PyPI:
python3 -m pip install --upgrade pandas
Please report any issues with the release on the [pandas issue tracker](https://togithub.com/pandas-dev/pandas/issues).
### [`v1.2.0`](https://togithub.com/pandas-dev/pandas/releases/v1.2.0)
[Compare Source](https://togithub.com/pandas-dev/pandas/compare/v1.1.5...v1.2.0)
This release includes some new features, bug fixes, and performance improvements. We recommend that all users upgrade to this version.
See the [full whatsnew](https://pandas.pydata.org/pandas-docs/version/1.2.0/whatsnew/v1.2.0.html) for a list of all the changes.
The release will be available on the defaults and conda-forge channels:
conda install -c conda-forge pandas
Or via PyPI:
python3 -m pip install --upgrade pandas
Please report any issues with the release on the [pandas issue tracker](https://togithub.com/pandas-dev/pandas/issues).
</details>
---
### Configuration
📅 **Schedule**: At any time (no schedule defined).
🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.
♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found.
🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.
---
This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/python-storage).
@chalmerlowechalmerlowe mentioned this pull request Apr 7, 2026
Merged
9 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@waprinwaprinwaprin left review comments
@theacodestheacodestheacodes approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@qiwzhang@jeffmendoza@waprin@theacodes@googlebot