Skip to content

fix: removes samples and tests for parameterized queries - #6889

Merged
leahecole merged 5 commits into
masterfrom
datalab-migration-parameterized-queries
Oct 11, 2021
Merged

fix: removes samples and tests for parameterized queries#6889
leahecole merged 5 commits into
masterfrom
datalab-migration-parameterized-queries

Conversation

@meredithslota

Copy link
Copy Markdown
Contributor

Description

Fixes#6770
Samples are being removed from docs in cl/401870628, this PR removes samples and related tests

@meredithslota
meredithslota requested review from a team and shollyman as code ownersOctober 8, 2021 22:50
@google-clagoogle-claBot added the cla: yes This human has signed the Contributor License Agreement. label Oct 8, 2021
@snippet-bot

snippet-botBot commented Oct 8, 2021

Copy link
Copy Markdown
You are about to delete the following frozen region tags.

Here is the summary of changes.

You are about to delete 5 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-labelproduct-auto-labelBot added the samples Issues that are directly related to samples. label Oct 8, 2021
@meredithslotameredithslota added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 8, 2021
@meredithslota

Copy link
Copy Markdown
ContributorAuthor

Do not merge until the CL is merge so we don't break docs. :)

@leahecole

Copy link
Copy Markdown
Collaborator

Thanks Meredith!

Comment threadbigquery/datalab-migration/samples_test.py
@meredithslota

Copy link
Copy Markdown
ContributorAuthor

Samples have been removed from https://cloud.google.com/bigquery/docs/datalab-migration.

@meredithslotameredithslota removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 11, 2021
@leahecole

Copy link
Copy Markdown
Collaborator

3.10 failures expected and tracked #6902

@leahecole
leahecole merged commit 00dc7de into masterOct 11, 2021
@leahecole
leahecole deleted the datalab-migration-parameterized-queries branch October 11, 2021 22:50
gcf-merge-on-greenBot pushed a commit to googleapis/python-bigquery that referenced this pull request Oct 29, 2021
Follow-up to GoogleCloudPlatform/python-docs-samples#6889, which removed a BigQuery magics sample for using query parameters.
Note: jupyter_tutorial_test.py is a copy of what is in the `samples/snippets`
folder. Once the docs have been updated to point to this new version, we can
remove that copy and remove the Jupyter/IPython depedencencies from
`samples/snippets/requirements.txt`.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
- [ ] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/python-bigquery/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
- [ ] Ensure the tests and linter pass
- [ ] Code coverage does not decrease (if any source code was changed)
- [ ] Appropriate docs were updated (if necessary)
abdelmegahedgoogle pushed a commit to abdelmegahedgoogle/python-bigquery that referenced this pull request Apr 17, 2023
Follow-up to GoogleCloudPlatform/python-docs-samples#6889, which removed a BigQuery magics sample for using query parameters.
Note: jupyter_tutorial_test.py is a copy of what is in the `samples/snippets`
folder. Once the docs have been updated to point to this new version, we can
remove that copy and remove the Jupyter/IPython depedencencies from
`samples/snippets/requirements.txt`.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
- [ ] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/python-bigquery/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
- [ ] Ensure the tests and linter pass
- [ ] Code coverage does not decrease (if any source code was changed)
- [ ] Appropriate docs were updated (if necessary)
parthea pushed a commit to googleapis/google-cloud-python that referenced this pull request Mar 6, 2026
Follow-up to GoogleCloudPlatform/python-docs-samples#6889, which removed a BigQuery magics sample for using query parameters.
Note: jupyter_tutorial_test.py is a copy of what is in the `samples/snippets`
folder. Once the docs have been updated to point to this new version, we can
remove that copy and remove the Jupyter/IPython depedencencies from
`samples/snippets/requirements.txt`.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
- [ ] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/python-bigquery/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
- [ ] Ensure the tests and linter pass
- [ ] Code coverage does not decrease (if any source code was changed)
- [ ] Appropriate docs were updated (if necessary)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yesThis human has signed the Contributor License Agreement.samplesIssues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bigquery.datalab-migration.samples_test: test_datalab_magic_parameterized_query failed

4 participants

@meredithslota@leahecole@tswast@busunkim96