Uh oh!
There was an error while loading. Please reload this page.
Conversation
theacodes
suggested changes
Dec 5, 2016
Contributor
There was a problem hiding this comment.
Can you do two separate sample functions instead of one?
ContributorAuthor
There was a problem hiding this comment.
Done.
Yes, splitting into separate functions should make it a little easier to talk about in the docs I write for this, too.
theacodes
suggested changes
Dec 5, 2016
theacodes
left a comment
Contributor
There was a problem hiding this comment.
Do you need both sync and async? We already have a comprehensive sample on async querying, is it worthwhile to duplicate here or would a comment mentioning that you could also do this async work?
| print_results(query_job.results()) | ||
| def main(use_named_params=False, corpus='romeoandjuliet', min_word_count=100): |
theacodes
commented
Dec 6, 2016
Contributor
@tswast a new bigquery version has been released. |
tswast
commented
Dec 6, 2016
ContributorAuthor
Thanks. I've updated the package and deleted the async sample. You're right. They are so similar, it's probably not worth including both. |
Available in latest version of google-cloud-bigquery (0.22.0), so upgrades the requirement, too.
theacodes
approved these changes
Dec 6, 2016
plamut pushed a commit
to plamut/python-bigquery
that referenced
this pull request
Jun 25, 2020
…tform/python-docs-samples#699) Available in latest version of google-cloud-bigquery (0.22.0), so upgrades the requirement, too.
plamut pushed a commit
to plamut/python-bigquery
that referenced
this pull request
Jul 22, 2020
…tform/python-docs-samples#699) Available in latest version of google-cloud-bigquery (0.22.0), so upgrades the requirement, too.
shollyman pushed a commit
to googleapis/python-bigquery
that referenced
this pull request
Jul 22, 2020
…on-docs-samples#699) Available in latest version of google-cloud-bigquery (0.22.0), so upgrades the requirement, too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This query syntax is supported in the not-yet-released version of google-cloud-python in googleapis/google-cloud-python#2776.
I've added the do not merge label, since we should wait for the next google-cloud-python release, but the sample should be ready to review.