Skip to content

Add KMS quickstart - #753

Merged
theacodes merged 1 commit into
masterfrom
kms
Jan 11, 2017
Merged

Add KMS quickstart#753
theacodes merged 1 commit into
masterfrom
kms

Conversation

@jmdobry

Copy link
Copy Markdown
Member

No description provided.

@jmdobryjmdobry self-assigned this Jan 11, 2017
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 11, 2017
Comment threadkms/api/quickstart.py Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is no longer needed, googleapiclient can figure out application default credentials on its own.

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Comment threadkms/api/quickstart.py Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Likewise here.

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Comment threadkms/api/quickstart.py Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make parent its own variable, please.

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Comment threadkms/api/quickstart.py Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

request and response, we don't get charged by the letter.

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@theacodes
theacodes merged commit fa8bc81 into masterJan 11, 2017
@theacodes
theacodes deleted the kms branch January 11, 2017 18:57
@theacodes

Copy link
Copy Markdown
Contributor

Thank you, @jmdobry!

Linchin pushed a commit that referenced this pull request Aug 18, 2025
…licies (#753)
* feat: Add include_recaptcha_script for as a new action in firewall policies
PiperOrigin-RevId: 612851792
Source-Link: googleapis/googleapis@49ea2c0
Source-Link: https://github.com/googleapis/googleapis-gen/commit/460fdcbbbe00f35b1c591b1f3ef0c77ebd3ce277
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNDYwZmRjYmJiZTAwZjM1YjFjNTkxYjFmM2VmMGM3N2ViZDNjZTI3NyJ9
* 🦉 Updates from OwlBot post-processor
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
---------
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@jmdobry@theacodes@googlebot