Skip to content

Hackathon/Codelab vision sample - #788

Merged
theacodes merged 18 commits into
masterfrom
hackathon-vision-sample
Feb 17, 2017
Merged

Hackathon/Codelab vision sample#788
theacodes merged 18 commits into
masterfrom
hackathon-vision-sample

Conversation

@ryanmats

@ryanmatsryanmats commented Feb 8, 2017

Copy link
Copy Markdown
Contributor

A work in progress for EDU hackathons / Codelab.

@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 8, 2017
@ryanmats

Copy link
Copy Markdown
ContributorAuthor

Still TODO: use Jinja2 for HTML output, README instructions

@ryanmatsryanmats changed the title Hackathon vision sampleHackathon/Codelab vision sampleFeb 14, 2017

@theacodestheacodes left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No tests?

Comment threadappengine/flexible/vision/main.py Outdated
@@ -0,0 +1,127 @@
# Copyright 2015 Google Inc. All Rights Reserved.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2017?

Comment threadappengine/flexible/vision/main.py Outdated
from google.cloud import vision


CLOUD_STORAGE_BUCKET = '<your-storage-bucket>'

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use os.environ and env_variables in app.yaml? (or do you have a good reason for this?)

@ryanmats

Copy link
Copy Markdown
ContributorAuthor

will add test(s) soon

@theacodes

Copy link
Copy Markdown
Contributor

@ryanmats this looks good, I'd just prefer we put it under /codelabs/flex_and_vision or similar.

@theacodes

Copy link
Copy Markdown
Contributor

Please create a bug for yourself to add tests.

@theacodes
theacodes merged commit 26eb8ce into masterFeb 17, 2017
@theacodes
theacodes deleted the hackathon-vision-sample branch February 17, 2017 21:56
chalmerlowe pushed a commit that referenced this pull request Apr 7, 2026
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@ryanmats@theacodes@googlebot