Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 6.7k
test: reduce testing to 2 python versions per sample#8875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Changes from all commits
File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -21,8 +21,11 @@ | ||||||
| # https://github.com/GoogleCloudPlatform/python-docs-samples/blob/main/noxfile_config.py | ||||||
| TEST_CONFIG_OVERRIDE = { | ||||||
| # You can opt out from the test for specific Python versions. | ||||||
| "ignored_versions": ["2.7", "3.6"], | ||||||
| # You can opt out specific Python versions from the test. | ||||||
| # To save resources, please consider testing 2 versions at most. | ||||||
| # Test min and max supported versions which are python 3.7 and 3.11 | ||||||
| # Ignoring python 2.7 which is no longer supported. | ||||||
| "ignored_versions": ["2.7", "3.8", "3.9", "3.10"], | ||||||
Collaborator There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
| ||||||
| # Old samples are opted out of enforcing Python type hints | ||||||
| # All new samples should feature them | ||||||
| "enforce_type_hints": False, | ||||||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -21,8 +21,11 @@ | ||||||
| # https://github.com/GoogleCloudPlatform/python-docs-samples/blob/main/noxfile_config.py | ||||||
| TEST_CONFIG_OVERRIDE = { | ||||||
| # You can opt out from the test for specific Python versions. | ||||||
| "ignored_versions": ["2.7", "3.6"], | ||||||
| # You can opt out specific Python versions from the test. | ||||||
| # To save resources, please consider testing 2 versions at most. | ||||||
| # Test min and max supported versions which are python 3.7 and 3.11 | ||||||
| # Ignoring python 2.7 which is no longer supported. | ||||||
| "ignored_versions": ["2.7", "3.8", "3.9", "3.10"], | ||||||
Collaborator There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
| ||||||
| # Old samples are opted out of enforcing Python type hints | ||||||
| # All new samples should feature them | ||||||
| "enforce_type_hints": False, | ||||||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -21,8 +21,11 @@ | ||||||
| # https://github.com/GoogleCloudPlatform/python-docs-samples/blob/main/noxfile_config.py | ||||||
| TEST_CONFIG_OVERRIDE = { | ||||||
| # You can opt out from the test for specific Python versions. | ||||||
| "ignored_versions": ["2.7", "3.6"], | ||||||
| # You can opt out specific Python versions from the test. | ||||||
| # To save resources, please consider testing 2 versions at most. | ||||||
| # Test min and max supported versions which are python 3.7 and 3.11 | ||||||
Collaborator There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
| ||||||
| # Ignoring python 2.7 which is no longer supported. | ||||||
| "ignored_versions": ["2.7", "3.8", "3.9", "3.10"], | ||||||
Collaborator There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
| ||||||
| # Old samples are opted out of enforcing Python type hints | ||||||
| # All new samples should feature them | ||||||
| "enforce_type_hints": False, | ||||||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -21,8 +21,11 @@ | ||||||
| # https://github.com/GoogleCloudPlatform/python-docs-samples/blob/main/noxfile_config.py | ||||||
| TEST_CONFIG_OVERRIDE = { | ||||||
| # You can opt out from the test for specific Python versions. | ||||||
| "ignored_versions": ["2.7", "3.6"], | ||||||
| # You can opt out specific Python versions from the test. | ||||||
| # To save resources, please consider testing 2 versions at most. | ||||||
| # Test min and max supported versions which are python 3.7 and 3.11 | ||||||
Collaborator There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
| ||||||
| # Ignoring python 2.7 which is no longer supported. | ||||||
| "ignored_versions": ["2.7", "3.8", "3.9", "3.10"], | ||||||
Collaborator There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
| ||||||
| # Old samples are opted out of enforcing Python type hints | ||||||
| # All new samples should feature them | ||||||
| "enforce_type_hints": False, | ||||||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -21,8 +21,11 @@ | ||||||
| # https://github.com/GoogleCloudPlatform/python-docs-samples/blob/main/noxfile_config.py | ||||||
| TEST_CONFIG_OVERRIDE = { | ||||||
| # You can opt out from the test for specific Python versions. | ||||||
| "ignored_versions": ["2.7", "3.6"], | ||||||
| # You can opt out specific Python versions from the test. | ||||||
| # To save resources, please consider testing 2 versions at most. | ||||||
| # Test min and max supported versions which are python 3.7 and 3.11 | ||||||
Collaborator There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
| ||||||
| # Ignoring python 2.7 which is no longer supported. | ||||||
| "ignored_versions": ["2.7", "3.8", "3.9", "3.10"], | ||||||
Collaborator There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
| ||||||
| # Old samples are opted out of enforcing Python type hints | ||||||
| # All new samples should feature them | ||||||
| "enforce_type_hints": False, | ||||||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -21,8 +21,11 @@ | ||||||
| # https://github.com/GoogleCloudPlatform/python-docs-samples/blob/main/noxfile_config.py | ||||||
| TEST_CONFIG_OVERRIDE = { | ||||||
| # You can opt out from the test for specific Python versions. | ||||||
| "ignored_versions": ["2.7", "3.6"], | ||||||
| # You can opt out specific Python versions from the test. | ||||||
| # To save resources, please consider testing 2 versions at most. | ||||||
| # Test min and max supported versions which are python 3.7 and 3.11 | ||||||
Collaborator There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
| ||||||
| # Ignoring python 2.7 which is no longer supported. | ||||||
| "ignored_versions": ["2.7", "3.8", "3.9", "3.10"], | ||||||
Collaborator There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
| ||||||
| # Old samples are opted out of enforcing Python type hints | ||||||
| # All new samples should feature them | ||||||
| "enforce_type_hints": False, | ||||||
| Original file line number | Diff line number | Diff line change | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -21,8 +21,11 @@ | ||||||||||||||
| # https://github.com/GoogleCloudPlatform/python-docs-samples/blob/main/noxfile_config.py | ||||||||||||||
| TEST_CONFIG_OVERRIDE = { | ||||||||||||||
| # You can opt out from the test for specific Python versions. | ||||||||||||||
| "ignored_versions": ["2.7", "3.6"], | ||||||||||||||
| # You can opt out specific Python versions from the test. | ||||||||||||||
| # To save resources, please consider testing 2 versions at most. | ||||||||||||||
| # Test min and max supported versions which are python 3.7 and 3.11 | ||||||||||||||
| # Ignoring python 2.7 which is no longer supported. | ||||||||||||||
| "ignored_versions": ["2.7", "3.8", "3.9", "3.10"], | ||||||||||||||
Comment on lines
+26
to
+28
Collaborator There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
| ||||||||||||||
| # Old samples are opted out of enforcing Python type hints | ||||||||||||||
| # All new samples should feature them | ||||||||||||||
| "enforce_type_hints": False, | ||||||||||||||
| Original file line number | Diff line number | Diff line change | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -21,8 +21,11 @@ | ||||||||||||||
| # https://github.com/GoogleCloudPlatform/python-docs-samples/blob/main/noxfile_config.py | ||||||||||||||
| TEST_CONFIG_OVERRIDE = { | ||||||||||||||
| # You can opt out from the test for specific Python versions. | ||||||||||||||
| "ignored_versions": ["2.7", "3.6"], | ||||||||||||||
| # You can opt out specific Python versions from the test. | ||||||||||||||
| # To save resources, please consider testing 2 versions at most. | ||||||||||||||
| # Test min and max supported versions which are python 3.7 and 3.11 | ||||||||||||||
| # Ignoring python 2.7 which is no longer supported. | ||||||||||||||
| "ignored_versions": ["2.7", "3.8", "3.9", "3.10"], | ||||||||||||||
Comment on lines
+26
to
+28
Collaborator There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
| ||||||||||||||
| # Old samples are opted out of enforcing Python type hints | ||||||||||||||
| # All new samples should feature them | ||||||||||||||
| "enforce_type_hints": False, | ||||||||||||||
| Original file line number | Diff line number | Diff line change | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -21,8 +21,11 @@ | ||||||||||||||
| # https://github.com/GoogleCloudPlatform/python-docs-samples/blob/main/noxfile_config.py | ||||||||||||||
| TEST_CONFIG_OVERRIDE = { | ||||||||||||||
| # You can opt out from the test for specific Python versions. | ||||||||||||||
| 'ignored_versions': ["2.7"], | ||||||||||||||
| # You can opt out specific Python versions from the test. | ||||||||||||||
| # To save resources, please consider testing 2 versions at most. | ||||||||||||||
| # Test min and max supported versions which are python 3.7 and 3.11 | ||||||||||||||
| # Ignoring python 2.7 which is no longer supported. | ||||||||||||||
| "ignored_versions": ["2.7", "3.8", "3.9", "3.10"], | ||||||||||||||
Comment on lines
+26
to
+28
Collaborator There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
| ||||||||||||||
| # An envvar key for determining the project id to use. Change it | ||||||||||||||
| # to 'BUILD_SPECIFIC_GCLOUD_PROJECT' if you want to opt in using a | ||||||||||||||
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.