Skip to content

fix: restore python 3.11 in samples docker image - #9131

Merged
parthea merged 8 commits into
mainfrom
parthea-patch-1
Feb 15, 2023
Merged

fix: restore python 3.11 in samples docker image#9131
parthea merged 8 commits into
mainfrom
parthea-patch-1

Conversation

@parthea

Copy link
Copy Markdown
Collaborator

Towards #8873

This change was originally made in #8861 and reverted in #9003. The reason for reverting the change is because of an issue where the docker build step would time out. The samples docker image is no longer built on the fly in presubmits and we no longer have the docker build step.

@product-auto-labelproduct-auto-labelBot added the samples Issues that are directly related to samples. label Feb 15, 2023
@parthea
parthea marked this pull request as ready for review February 15, 2023 16:21
@parthea
parthea requested a review from a team as a code ownerFebruary 15, 2023 16:21

@m-strzelczykm-strzelczyk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dandhleedandhlee left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@parthea

parthea commented Feb 15, 2023

Copy link
Copy Markdown
CollaboratorAuthor

Merging as these changes are not tested during presubmits and this specific change was previously merged into main in #8861.

@parthea
parthea merged commit 8c1aef3 into mainFeb 15, 2023
@parthea
parthea deleted the parthea-patch-1 branch February 15, 2023 17:32
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

samplesIssues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@parthea@m-strzelczyk@dandhlee