Uh oh!
There was an error while loading. Please reload this page.
fix(oslogin): Fix error reporting for OSLogin - #9222
Merged
Conversation
Make sure to properly handle TimeoutError to avoid [this](https://source.cloud.google.com/results/invocations/cf985939-8124-4a15-bc71-bfab62e327cb/targets/github%2Fpython-docs-samples%2Fcompute%2Foslogin/tests).
m-strzelczyk
marked this pull request as ready for review
March 3, 2023 17:08
savijatv
reviewed
Mar 5, 2023
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
rsamborski
approved these changes
Mar 6, 2023
leahecole
commented
Mar 6, 2023
Collaborator
removed automerge til second approval is there - @savijatv maybe you can do a quick re-review given that you left comments? |
kweinmeister
approved these changes
Mar 6, 2023
telpirion pushed a commit
that referenced
this pull request
Mar 13, 2023
* fix(oslogin): Fix error reporting for OSLogin Make sure to properly handle TimeoutError to avoid [this](https://source.cloud.google.com/results/invocations/cf985939-8124-4a15-bc71-bfab62e327cb/targets/github%2Fpython-docs-samples%2Fcompute%2Foslogin/tests). * Update oslogin_service_account_ssh.py * Update oslogin_service_account_ssh.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure to properly handle TimeoutError to avoid this.