Skip to content

chore: autocorrect rubocop offenses in appengine and jobs samples - #1908

Merged
torreypayne merged 2 commits into
GoogleCloudPlatform:mainfrom
torreypayne:style/fix-rubocop-errors
Aug 4, 2026
Merged

chore: autocorrect rubocop offenses in appengine and jobs samples#1908
torreypayne merged 2 commits into
GoogleCloudPlatform:mainfrom
torreypayne:style/fix-rubocop-errors

Conversation

@torreypayne

Copy link
Copy Markdown
Member

Fixes Rubocop errors reported in presubmit:

  • appengine/rails-hello_world/bin/setup: Style/MethodDefParentheses
  • appengine/standard-static-files/rails/bin/setup: Style/MethodDefParentheses
  • appengine/static_files/rails/bin/setup: Style/MethodDefParentheses
  • jobs/V3/filter_search_sample.rb: Layout/IndentationWidth, Layout/ClosingParenthesisIndentation

Autocorrected via Rubocop CLI (bundle exec rubocop -a).

@torreypayne
torreypayne requested review from a team as code ownersJuly 31, 2026 21:32
@product-auto-labelproduct-auto-labelBot added the samples Issues that are directly related to samples. label Jul 31, 2026

@gemini-code-assistgemini-code-assistBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes parentheses from the system! method definition in several setup scripts and adjusts the indentation of the max_compensation parameter in jobs/V3/filter_search_sample.rb. The review feedback correctly points out that this indentation change introduces a layout inconsistency relative to the sibling min_compensation parameter and suggests a uniform formatting structure for better readability.

Comment threadjobs/V3/filter_search_sample.rb Outdated
@aandreassa

Copy link
Copy Markdown
Contributor

Lets also use chore just in case. Not sure what style does.

@torreypaynetorreypayne changed the title style: autocorrect rubocop offenses in appengine and jobs sampleschore: autocorrect rubocop offenses in appengine and jobs samplesAug 3, 2026
@torreypayne
torreypayne merged commit f2bf7ee into GoogleCloudPlatform:mainAug 4, 2026
10 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

samplesIssues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@torreypayne@aandreassa