Uh oh!
There was an error while loading. Please reload this page.
Refactor Logging Quickstart spec and fix by adding order clause to entry fetch - #90
Merged
Merged
Conversation
…try fetch
- logging.entries filter: was not working without additional order: option
- simplify log name to "quickstart_log_#{Time.now.to_i}"
- always try to delete log after spec runs, allowing for NotFound exceptions
- refactor entry lookup into a helper methodfrankyn
commented
Oct 13, 2016
Contributor
quickstart passed. sample spec failed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor Logging Quickstart spec and fix by adding order clause to entry fetch
logging.entries filter:was not working without additionalorder:option"quickstart_log_#{Time.now.to_i}"