Uh oh!
There was an error while loading. Please reload this page.
Fix for marker content update bug - #295
Conversation
ebidel
commented
May 3, 2016
Please add a test. |
ebidel
commented
Jun 6, 2016
ping |
tst-dhudlow
commented
Jun 15, 2016
When I run the current tests with |
ebidel
commented
Jun 15, 2016
Running them myself, it looks like there are errors. I can help get that working again. Mind just adding a test for yourself? |
tst-dhudlow
commented
Jun 20, 2016
Sure thing, I'll give it a shot. I just figured I was probably not configured correctly. |
tst-dhudlow
commented
Jun 29, 2016
FYI, still working on reproducing this during tests. Having a bit of a time with it, but making progress. |
tst-dhudlow
commented
Jun 29, 2016
ebidel
commented
Jul 5, 2016
TBH, I'm not sure about this change. Generally, hacking around timing issues like this means there's an underlying problem that needs to be addressed. In this case, #286 is using |
tst-dhudlow
commented
Jul 5, 2016
Well, it's possible you're right that issues related to #294 are the real problem. I could try to verify this by tweaking the test, but it's my understanding that the issues is caused because when the marker is detached, its content is updated, and then it's re-attached, it doesn't update its content. Templates detach stuff from the DOM so they can be re-used and that's why this came up here. The question is, do you want content to be updated if it is added/modified while the marker is in a detached state? |
See #286