Skip to content
This repository was archived by the owner on Apr 19, 2026. It is now read-only.

2.0 preview - #361

Merged
e111077 merged 5 commits into
GoogleWebComponents:2.0-previewfrom
samuelli:2.0-preview
May 11, 2017
Merged

2.0 preview#361
e111077 merged 5 commits into
GoogleWebComponents:2.0-previewfrom
samuelli:2.0-preview

Conversation

@samuelli

Copy link
Copy Markdown
Contributor

No description provided.

@e111077e111077 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update README with slot="markers" breaking change

Comment threadbower.json Outdated
"iron-selector": "PolymerElements/iron-selector#^1.5.2"
},
"devDependencies": {
"web-component-tester": "*",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you pin this to a specific version of wct?

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@samuelli

Copy link
Copy Markdown
ContributorAuthor

Please update README with slot="markers" breaking change

Done

@samuelli

Copy link
Copy Markdown
ContributorAuthor

Who has merging powers? @ebidel?

@e111077

e111077 commented May 1, 2017

Copy link
Copy Markdown
Contributor

oh I do apparently, but we aren't merging to master yet

@loopingz

Copy link
Copy Markdown

Nice thanks ! Could it be possible to merge to a 2.0-preview branch like other components ?
https://github.com/GoogleWebComponents/google-youtube/branches

@samuelli

Copy link
Copy Markdown
ContributorAuthor

I can't make a new branch. @e111077?

@e111077
e111077 changed the base branch from master to 2.0-previewMay 11, 2017 18:59
@e111077

Copy link
Copy Markdown
Contributor

Made

@e111077
e111077 merged commit 88d323b into GoogleWebComponents:2.0-previewMay 11, 2017
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@samuelli@e111077@loopingz@googlebot