Uh oh!
There was an error while loading. Please reload this page.
Add map bounds to available data. - #397
Conversation
googlebot
commented
Sep 8, 2017
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
francescortiz
commented
Sep 8, 2017
I signed it! |
googlebot
commented
Sep 8, 2017
CLAs look good, thanks! |
francescortiz
commented
Sep 10, 2017
I added the option to disable fullscreen control. |
…howing back a map. Marker events where being set prior proper marker initialization. This ensures the marker is initialized is the map is set.
francescortiz
commented
Sep 13, 2017
Added commit that fixes issues with Elm virtual DOM after removing the map and showing it again. |
simonh1000
commented
Aug 18, 2019
can't help thinking the Elm stuff should go in a seperate PR with a full explanation of why it was necessary and the consequences for non-Em users. But beyond that I really hope someone gets round to reviewing this as this is an important feaure |
francescortiz
commented
Aug 19, 2019
The issue here is not related to Elm. Elm only made it surface. The situation is that markers can be added an removed to the DOM. The HTML DOM allows that and webcomponents honor that. The fix here is to check for the existence of the |
I am integrating google-map with an elm project and at a certain point I needed to have the map bounds available without callbacks.