Skip to content

Put secretKey inside CreateUserInput? #52

Description

@lorensr

We say it's best practice to use a single input type as an argument, and then we do this:

typeMutation {
createUser(user: CreateUserInput!, secretKey: String!): User
}

I created it that way because secretKey felt like something out of band, like you'd put it in a header, except it's more convenient to be an argument given it's only used in this one resolver. Is that a good reason, in which case we could add an explanation, or should we just move it inside the input object like this?

inputCreateUserInput {
firstName: String!lastName: String!username: String!email: String!authId: String!secretKey: String!
}

Thanks to @Borales for asking

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions