Uh oh!
There was an error while loading. Please reload this page.
Fix too many locals in wasm binary - #1159
Merged
Merged
Conversation
nat-rixforce-pushed
the
master
branch
2 times, most recently
from
April 24, 2023 18:09
1ab1514 to
9fb12afCompareUh oh!
There was an error while loading. Please reload this page.
this fixes the issue that rust creates too many wasm locals in non-optimized builds. That lead to a compile error in such builds.
TrueDoctor
approved these changes
Apr 24, 2023
Keavon added a commit
that referenced
this pull request
Jul 30, 2023
Split function into smaller non-inlinable ones this fixes the issue that rust creates too many wasm locals in non-optimized builds. That lead to a compile error in such builds. Co-authored-by: Keavon Chambers <keavon@keavon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split function into smaller non-inlinable ones.
This fixes the issue that rust creates too many wasm locals in non-optimized builds. That lead to a compile error in such builds.