Uh oh!
There was an error while loading. Please reload this page.
Implement backend part of the layer selection - #172
Merged
Conversation
Deploying with |
| Latest commit: | 6efb8fd |
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d7a02d4f.graphite-master.pages.dev |
Keavon
requested changes
Jun 9, 2021
Keavon
left a comment
Member
There was a problem hiding this comment.
Reviewable status: 0 of 11 files reviewed, 1 unresolved discussion (waiting on @TrueDoctor)
client/web/wasm/src/document.rs, line 109 at r1 (raw file):
/// Update the list of selected layers. The layer paths have to be stored in one array and are separated by LayerId::MAX #[wasm_bindgen] pub fn select_layer(paths: Vec<LayerId>) -> Result<(), JsValue> {
Rename select_layers?
TrueDoctor
commented
Jun 9, 2021
TrueDoctor
left a comment
MemberAuthor
There was a problem hiding this comment.
Reviewable status: 0 of 11 files reviewed, 1 unresolved discussion (waiting on @Keavon)
client/web/wasm/src/document.rs, line 109 at r1 (raw file):
Previously, Keavon (Keavon Chambers) wrote…
Rename
select_layers?
Done.
TrueDoctor added a commit
that referenced
this pull request
Jun 9, 2021
* Implement backend part of the layer selection Change arg to IconButton component Add basic layer selection mechanism Almost good version Clean up print statements and add some comments Simplified the layer selection mechanism Remove redundant rule for 'no-param-reassign'
Keavon pushed a commit
that referenced
this pull request
Jul 30, 2023
* Implement backend part of the layer selection
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisite for #166
This change is