Uh oh!
There was an error while loading. Please reload this page.
Change eyedropper to use correct message - #327
Merged
Merged
Conversation
Deploying with |
| Latest commit: | 3996673 |
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2ae6fcec.graphite-master.pages.dev |
Keavon
approved these changes
Aug 2, 2021
Keavon pushed a commit
that referenced
this pull request
Jun 16, 2022
Keavon pushed a commit
that referenced
this pull request
Jul 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes#326
Diagnosed as a regression of #300 due to #305
The fix simply was due to not changing the message that the eyedropper tool dispatched. It originally used
FrontendMessage::UpdateWorkingColors, which was the original cause of loopy behavior. When the looping tendency was fixed, this should have been replaced withToolMessage::SelectPrimaryColorandToolMessage::SelectSecondaryColor. This PR does that replacement, which then propagates the change with aFrontendMessage.This change is