Uh oh!
There was an error while loading. Please reload this page.
Fix g suggestion path tool - #3538
Closed
Annonnymmousss wants to merge 1 commit into
Closed
Conversation
Annonnymmousss
marked this pull request as draft
December 27, 2025 20:26
Annonnymmousss
marked this pull request as ready for review
December 27, 2025 23:33
ContributorAuthor
Screen.Recording.2025-12-28.at.5.04.30.AM.movIg it's fine now. If there is any better approach or any breakage please tell me I didn't find any other approach to provide the information of transformation. |
Annonnymmousssforce-pushed
the
fix-G_suggestion-path_tool
branch
from
January 18, 2026 21:48
8257c1e to
fe45090CompareAnnonnymmousss
commented
Feb 3, 2026
ContributorAuthor
hey @0HyperCube is this the optimal method for the tagged issue? Kindly review this. Thankyou! |
0HyperCube
commented
Feb 3, 2026
Contributor
This seems like a reasonable approach. |
| } = tool_action_data; | ||
| update_dynamic_hints(self, responses, shape_editor, document, tool_data, tool_options, input.mouse.position); | ||
| if !tool_action_data.is_transforming { |
Contributor
There was a problem hiding this comment.
I'd suggest adding a comment here that explains why this check is required (perhaps link the GitHub issue?).
Otherwise it is quite unclear why this logic is in place for other contributors.
ContributorAuthor
There was a problem hiding this comment.
Done with adding comment. I hope it is clear.
Annonnymmousssforce-pushed
the
fix-G_suggestion-path_tool
branch
from
February 3, 2026 23:40
fe45090 to
3f97ae4CompareKeavon
commented
Feb 18, 2026
Member
Superseded by #3222. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixed overriding
Closes#3537
Screen.Recording.2025-12-28.at.1.46.12.AM.mov