Skip to content

Refactor font loading from per-document to the portfolio - #659

Merged
Keavon merged 8 commits into
masterfrom
default-font-cleanup
May 26, 2022
Merged

Refactor font loading from per-document to the portfolio#659
Keavon merged 8 commits into
masterfrom
default-font-cleanup

Conversation

@0HyperCube

@0HyperCube0HyperCube commented May 22, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

Closes#655

  • font_cache per document -> font_cache in portfolio (involved passing the font_cache to all tools)
  • TriggerFontLoad called from backend with default font
  • tool_data (primary/secondary colour) -> global_tool_data
  • data (for specific tool) -> tool_data
  • Reduce number of arguments to transition by using ToolActionHandlerData
  • Fix clippy lints (deriving Eq for many PartialEq structs / enums)
  • Merge conflict also resolved issue with clicking on menu lists.

@0HyperCube
0HyperCube requested a review from KeavonMay 22, 2022 08:16
@cloudflare-workers-and-pages

cloudflare-workers-and-pagesBot commented May 22, 2022•
edited
Loading

Copy link
Copy Markdown

Deploying with Cloudflare Pages Cloudflare Pages

Latest commit:08a9847
Status: ✅ Deploy successful!
Preview URL:https://e66fcd7b.graphite-master.pages.dev

View logs

Keavon
Keavon reviewed May 22, 2022
View reviewed changes
Comment threadfrontend/src/state-providers/fonts.ts Outdated
Comment threadfrontend/wasm/src/api.rs Outdated
Comment threadfrontend/src/state-providers/fonts.ts
@0HyperCube
0HyperCube marked this pull request as draft May 23, 2022 19:43
@KeavonKeavon changed the title Cleanup default font loadingRefactor default font loadingMay 23, 2022
@Keavon
Keavonforce-pushed the master branch 2 times, most recently from a86fd02 to fd95326CompareMay 26, 2022 07:28
@0HyperCube
0HyperCube marked this pull request as ready for review May 26, 2022 20:09
@0HyperCube
0HyperCube requested a review from KeavonMay 26, 2022 20:50
Keavon
Keavon approved these changes May 26, 2022
View reviewed changes

@KeavonKeavon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent improvements!

@KeavonKeavon changed the title Refactor default font loadingRefactor font loading from per-document to the portfolioMay 26, 2022
@Keavon
Keavon merged commit 4411599 into masterMay 26, 2022
@Keavon
Keavon deleted the default-font-cleanup branch May 26, 2022 23:27
Keavon added a commit that referenced this pull request Jun 16, 2022
@0HyperCube@Keavon
Refactor font loading from per-document to the portfolio (#659)
469e40d
* Cleanup default font loading
* Refactor fonts
* Fix menulist mouse navigation
* Format
* Formatting
* Move default font into consts.rs
Co-authored-by: Keavon Chambers <keavon@keavon.com>
@0HyperCube0HyperCube mentioned this pull request Jul 2, 2022
Merged
12 tasks
Keavon added a commit that referenced this pull request Jul 30, 2023
@0HyperCube@Keavon
Refactor font loading from per-document to the portfolio (#659)
8923b68
* Cleanup default font loading
* Refactor fonts
* Fix menulist mouse navigation
* Format
* Formatting
* Move default font into consts.rs
Co-authored-by: Keavon Chambers <keavon@keavon.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KeavonKeavonKeavon approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Move font loading from per-document to global on the editor

2 participants

@0HyperCube@Keavon