Skip to content

Implement viewport culling - #667

Merged
Keavon merged 8 commits into
masterfrom
Issue#608
Jun 10, 2022
Merged

Implement viewport culling#667
Keavon merged 8 commits into
masterfrom
Issue#608

Conversation

@mfish33

@mfish33mfish33 commented Jun 7, 2022

Copy link
Copy Markdown
Contributor

Closes#608

@cloudflare-workers-and-pages

cloudflare-workers-and-pagesBot commented Jun 7, 2022•
edited
Loading

Copy link
Copy Markdown

Deploying with Cloudflare Pages Cloudflare Pages

Latest commit:e9440a7
Status: ✅ Deploy successful!
Preview URL:https://773f7cad.graphite-master.pages.dev
Branch Preview URL:https://issue-608.graphite-master.pages.dev

View logs

@mfish33
mfish33 requested review from 0HyperCube and removed request for 0HyperCubeJune 7, 2022 18:11
@Keavon
Keavon requested a review from 0HyperCubeJune 10, 2022 18:48
@Keavon
Keavon marked this pull request as ready for review June 10, 2022 18:48
0HyperCube
0HyperCube approved these changes Jun 10, 2022
View reviewed changes

@0HyperCube0HyperCube left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Comment threadeditor/src/document/document_message_handler.rs Outdated
Comment threadeditor/src/document/document_message_handler.rs Outdated
Comment threadgraphene/src/layers/folder_layer.rs Outdated
@Keavon
Keavon merged commit f30b04b into masterJun 10, 2022
@Keavon
Keavon deleted the Issue#608 branch June 10, 2022 21:38
Keavon added a commit that referenced this pull request Jun 16, 2022
@mfish33@Keavon
Implement viewport culling (#667)
be717b3
* culling is working
* fixed tests
* Ready for review
* cleanup
* code review
* Fix import
Co-authored-by: Keavon Chambers <keavon@keavon.com>
Keavon added a commit that referenced this pull request Jul 30, 2023
@mfish33@Keavon
Implement viewport culling (#667)
a26a0dd
* culling is working
* fixed tests
* Ready for review
* cleanup
* code review
* Fix import
Co-authored-by: Keavon Chambers <keavon@keavon.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KeavonKeavonKeavon approved these changes
+1 more reviewer
@0HyperCube0HyperCube0HyperCube approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Viewport culling

3 participants

@mfish33@Keavon@0HyperCube