Skip to content

Add scaling by nudging with the Alt key - #990

Merged
Keavon merged 14 commits into
masterfrom
nudge-to-resize
Feb 7, 2023
Merged

Add scaling by nudging with the Alt key#990
Keavon merged 14 commits into
masterfrom
nudge-to-resize

Conversation

@Sahra-Zhou

@Sahra-ZhouSahra-Zhou commented Jan 26, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

@cloudflare-workers-and-pages

cloudflare-workers-and-pagesBot commented Jan 26, 2023•
edited
Loading

Copy link
Copy Markdown

Deploying with Cloudflare Pages Cloudflare Pages

Latest commit:df92c7b
Status:⚡️ Build in progress...

View logs

@Sahra-ZhouSahra-Zhou mentioned this pull request Jan 26, 2023
Closed
@Sahra-ZhouSahra-Zhou changed the title update current progress working on issue#930update current progress Closes #930Jan 26, 2023
@KeavonKeavon changed the title update current progress Closes #930Add scaling by nudging with the Alt keyJan 26, 2023
@Sahra-Zhou
Sahra-Zhou marked this pull request as draft January 27, 2023 00:01
@Keavon
Keavon removed their request for review January 30, 2023 00:55
@GraphiteEditorGraphiteEditor deleted a comment from Sahra-ZhouJan 30, 2023
@Sahra-Zhou
Sahra-Zhou marked this pull request as ready for review January 31, 2023 04:02
Keavon
Keavon requested changes Jan 31, 2023
View reviewed changes

@KeavonKeavon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The feature is looking good! There is a bug in an edge case: if you try to resize it down to zero, it behaves strangely. Please fix this by preventing the scaling of the layer to be less than 1px wide or 1px tall. If the nudge would cause it to be less than 1px (or 0 or even a negative number), reset it back to 1px wide or tall.

Comment threadeditor/src/messages/input_mapper/default_mapping.rs Outdated
Comment threadeditor/src/messages/input_mapper/default_mapping.rs Outdated
Comment threadeditor/src/messages/portfolio/document/document_message.rs Outdated
Comment threadeditor/src/messages/portfolio/document/document_message_handler.rs Outdated
Comment threadeditor/src/messages/portfolio/document/document_message.rs Outdated
Comment threadeditor/src/messages/portfolio/document/document_message_handler.rs Outdated
Comment threadeditor/src/messages/portfolio/document/document_message_handler.rs Outdated
Keavon
Keavon requested changes Jan 31, 2023
View reviewed changes

@KeavonKeavon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added more tips to simplify. But this isn't an exhaustive list. Please keep thinking about every way you can possibly make it even simpler and try those, since it still has a sizable chunk of complexity that can be cut out. This is a good exercise to learn Rust in the process.

Comment threadeditor/src/messages/portfolio/document/document_message_handler.rs Outdated
Comment threadeditor/src/messages/portfolio/document/document_message_handler.rs Outdated
Comment threadeditor/src/messages/portfolio/document/document_message_handler.rs Outdated
Comment threadeditor/src/messages/portfolio/document/document_message_handler.rs Outdated
Comment threadeditor/src/messages/portfolio/document/document_message_handler.rs Outdated
Comment threadeditor/src/messages/portfolio/document/document_message_handler.rs Outdated
@Keavon
Keavon merged commit b91de86 into masterFeb 7, 2023
@Keavon
Keavon deleted the nudge-to-resize branch February 7, 2023 09:14
Keavon added a commit that referenced this pull request Feb 8, 2023
@Sahra-ZhouShiro@Keavon
Add scaling by nudging with the Alt key (#990)
12d6818
* update current progress working on issue#930
* Issue#930: features other than local scaling implemented
* runs cargo fmt
* issue930: implemented features(local scaling disregraded) update: merged master branch and solved coflicts
* combined scaling and nudge feature
* combined scaling and nudge feature
* resolved issues when trying to scale below 1. pixel and other comments
* reduce code complexity
* reduce complexity
* Improve code readability/idiomaticness
* Add hints
---------
Co-authored-by: Shiro <shiro@damedane.local>
Co-authored-by: Keavon Chambers <keavon@keavon.com>
Keavon added a commit that referenced this pull request Jul 30, 2023
@Sahra-ZhouShiro@Keavon
Add scaling by nudging with the Alt key (#990)
77e69f4
* update current progress working on issue#930
* Issue#930: features other than local scaling implemented
* runs cargo fmt
* issue930: implemented features(local scaling disregraded) update: merged master branch and solved coflicts
* combined scaling and nudge feature
* combined scaling and nudge feature
* resolved issues when trying to scale below 1. pixel and other comments
* reduce code complexity
* reduce complexity
* Improve code readability/idiomaticness
* Add hints
---------
Co-authored-by: Shiro <shiro@damedane.local>
Co-authored-by: Keavon Chambers <keavon@keavon.com>
@KeavonKeavon mentioned this pull request Jun 16, 2026
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KeavonKeavonKeavon approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Alt+Arrows should nudge to resize the bottom/right edges of layers

2 participants

@Sahra-Zhou@Keavon