Skip to content

Uniq: Start implementation. - #121

Merged
bors[bot] merged 11 commits into
GrayJack:devfrom
marcospb19:implement-uniq
Aug 9, 2020
Merged

Uniq: Start implementation.#121
bors[bot] merged 11 commits into
GrayJack:devfrom
marcospb19:implement-uniq

Conversation

@marcospb19

@marcospb19 marcospb19 commented Aug 4, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

Started Uniq.

Progress:

  • Basic implementation
  • Review error messages
  • Flag: -c|--count
  • Flag: -d|--repeated
  • Flag: -f|--skip-fields=N Implemented in Uniq: fix -s and implement -f flags #131
  • Flag: -s|--skip-chars=N
  • Flag: -u|--unique

@marcospb19

marcospb19 commented Aug 4, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@GrayJack can you review it?

@GrayJack

GrayJack commented Aug 4, 2020

Copy link
Copy Markdown
Owner

Can you add uniq to all the toml files so it's tested on all platforms?

GrayJack
GrayJack reviewed Aug 4, 2020
View reviewed changes
Comment thread uniq/src/main.rs Outdated
@marcospb19

marcospb19 commented Aug 5, 2020

Copy link
Copy Markdown
Contributor Author

-d and -u are implemented, need to finish their tests, -c is also pending.

@marcospb19
marcospb19 requested a review from GrayJack August 7, 2020 20:20
@marcospb19

marcospb19 commented Aug 7, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

PR ready, one more review?

So, --fields is pending implementation but I could not understand exactly what this flag do when I was testing, after merging we can open an Issue for it.

GrayJack
GrayJack reviewed Aug 8, 2020
View reviewed changes
Comment thread uniq/src/main.rs Outdated
GrayJack
GrayJack reviewed Aug 8, 2020
View reviewed changes
Comment thread uniq/src/main.rs Outdated
Comment thread uniq/src/cli.rs Outdated
GrayJack
GrayJack requested changes Aug 8, 2020
View reviewed changes

@GrayJack GrayJack left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also update the table in the README.md in the status of the uniq? Should be Started since it still didn't implement the -f flag

Comment thread uniq/src/cli.rs Outdated
Comment thread uniq/src/cli.rs Outdated
Comment thread uniq/src/cli.rs Outdated
Comment thread uniq/src/cli.rs Outdated
@GrayJack

GrayJack commented Aug 8, 2020

Copy link
Copy Markdown
Owner

Sorry for so many reviews, I'm still not used to the VSCode plugin for PR reviews 😆

GrayJack
GrayJack reviewed Aug 9, 2020
View reviewed changes
Comment thread uniq/src/main.rs Outdated
@marcospb19
marcospb19 requested a review from GrayJack August 9, 2020 21:06
@GrayJack

GrayJack commented Aug 9, 2020

Copy link
Copy Markdown
Owner

bors r+

This was referenced Aug 9, 2020
Closed
Open
@bors

bors Bot commented Aug 9, 2020

Copy link
Copy Markdown
Contributor

Build succeeded:

@bors
bors Bot merged commit 54cc35c into GrayJack:dev Aug 9, 2020
@marcospb19 marcospb19 mentioned this pull request Aug 10, 2020
Closed
@marcospb19

marcospb19 commented Oct 19, 2020

Copy link
Copy Markdown
Contributor Author

There are several errors with the implementation of the -s flag, working on that for the implementation of -f.

@marcospb19 marcospb19 changed the title Uniq: Start implementation (in progress). Uniq: Start implementation. Nov 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GrayJack GrayJack GrayJack approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@marcospb19 @GrayJack