Skip to content

Expose closeable event listener in twisted - #25

Open
RazorBest wants to merge 10 commits into
HMaker:masterfrom
RazorBest:closeable-event-listener
Open

Expose closeable event listener in twisted#25
RazorBest wants to merge 10 commits into
HMaker:masterfrom
RazorBest:closeable-event-listener

Conversation

@RazorBest

@RazorBestRazorBest commented Aug 12, 2025

Copy link
Copy Markdown
Contributor

Implement the function create_listener, for pycdp.twisted, so the user can cancel it.

Remove _CLOSE_SENTINEL, because you can directly use Deferred.close to achieve the same effect.

Added tests for CDPEventListener.

There's still an isssue with the internal state. I don't know what should happen when aiter(listener) is called multiple times.

@RazorBestRazorBest changed the title Expose closeable event listenerExpose closeable event listener in twistedAug 12, 2025
@HMaker

Copy link
Copy Markdown
Owner

I think we should squash all commits into a single commit for better review and merging. Rebase your branch onto main and squash all the commits.

Thanks for your work.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@RazorBest@HMaker