Skip to content

Added collection to response context - #59

Open
raoashish10 wants to merge 1 commit into
HTTP-APIs:developfrom
raoashish10:develop
Open

Added collection to response context#59
raoashish10 wants to merge 1 commit into
HTTP-APIs:developfrom
raoashish10:develop

Conversation

@raoashish10

@raoashish10raoashish10 commented Oct 14, 2020

Copy link
Copy Markdown

Regarding #57

Checklist

  • My branch is up-to-date with upstream/develop branch.
  • Everything works and tested for Python 3.5.2 and above.

Description

So I have added the code and adds the Collection keyword in the context of the response but I am not sure about the code ie. I am not sure if the position of the code is apt and if this was the fix that was needed. So please guide me and let me know if there are mistakes.

Change logs

Added

  • Added Collection keyword in the response context generated.

@Mec-iS

Copy link
Copy Markdown
Contributor

@farazkhanfk7 do you think this is still useful?

@farazkhanfk7

farazkhanfk7 commented Jun 1, 2021

Copy link
Copy Markdown
Member

yes we can still add this. But I think it should be collections. Also this is only a single line change but we'll also have to update tests and add these changes in Context class of doc_writer.py.

@Mec-iSMec-iS added enhancement New feature or request GSOC-2021 labels Jun 11, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancementNew feature or requestGSOC-2021

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@raoashish10@Mec-iS@farazkhanfk7