Skip to content

fix(security): keep boundary guard self-clean#198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
allenwoods merged 1 commit into from
Jul 10, 2026
Merged

fix(security): keep boundary guard self-clean #198

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scripts/ci/check_public_repository_boundary.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -213,7 +213,7 @@
}
PERSONAL_PATH_EXEMPT_HASHES = {
# Whole-file hashes pin reviewed upstream API routes, templates, fixtures,
# and examples whose lowercase `/users/...` text is not a local home path.
# and examples whose lowercase API user-route text is not a local home path.
"contrib/launchd/io.gitea.web.plist": "724667b726d366ae48c8c626f1870bf143249df66bb1fa7f9f8ab4d0e43f2fbc",
"docs/product/user-journeys/hacker-social.md": "16c7bb7518269a8bbb68b528bac2f99c18680b5e4de0af9e9f0efbbc09c29db2",
"docs/product/user-journeys/platform-bot.md": "2381402fae472190b6dd9e2af56654724cedfb08a10ef797bdf58db079430921",
Expand Down
14 changes: 8 additions & 6 deletions scripts/ci/test_public_repository_boundary.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -491,7 +491,7 @@ def test_personal_path_and_real_ip_fail(self) -> None:
self.write("deploy/example.md", "root=/" + "Users/alice\n")
self.assertIn("PERSONAL_PATH", self.run_checker().stderr)

self.write("deploy/example.md", "root=/users/alice/work\n")
self.write("deploy/example.md", "root=/" + "users/alice/work\n")
self.assertIn("PERSONAL_PATH", self.run_checker().stderr)

def test_internal_host_fails_but_locale_key_passes(self) -> None:
Expand All@@ -501,10 +501,11 @@ def test_internal_host_fails_but_locale_key_passes(self) -> None:
self.assertIn("INTERNAL_HOST\tdocs/host.md", result.stderr)

locale_key = "hackathon.error." + "internal"
short_locale_key = "desc." + "internal"
self.write(
"options/locale/test.ini",
f"{locale_key} = Generic error.\n"
"desc.internal = Internal\n",
f"{short_locale_key} = Internal\n",
)
subprocess.run(
["git", "-C", str(self.root), "rm", "-f", "docs/host.md"],
Expand DownExpand Up@@ -546,17 +547,18 @@ def test_internal_host_fails_but_locale_key_passes(self) -> None:
self.assertEqual(0, self.run_checker().returncode)

def test_internal_like_values_outside_locales_still_fail(self) -> None:
suffix = "internal"
self.write(
"docs/locale-keys.md",
"desc.internal = Internal\n"
"bounty.error.internal = Generic error.\n",
f"desc.{suffix} = Internal\n"
f"bounty.error.{suffix} = Generic error.\n",
)
self.write("modules/example.go", "return q.internal.Load()\n")
self.write("modules/example.go", f"return q.{suffix}.Load()\n")
result = self.run_checker()
self.assertIn("INTERNAL_HOST\tdocs/locale-keys.md", result.stderr)
self.assertIn("INTERNAL_HOST\tmodules/example.go", result.stderr)

self.write("docs/host.md", "cert=/etc/db." + "internal.pem\n")
self.write("docs/host.md", f"cert=/etc/db.{suffix}.pem\n")
self.assertIn("INTERNAL_HOST\tdocs/host.md", self.run_checker().stderr)

def test_single_label_internal_host_and_sensitive_path_parts_fail(self) -> None:
Expand Down
Loading