Prepare uphold 1.19.0 - #208
Merged
Merged
Conversation
Ten changes since 1.18.0, every one answering a consumer sweep. The shim steps past a PATH shim of somebody else's instead of looping through it, a literal source is asked once per process, and a bare issue number after a list separator is a tracker reference. An `[override.<id>]` table narrows where an inherited rule reads without restating it; tracker references in code are the `code-residue` set and a documentation line is reported under one id; a committed credential in source is a quoted literal and the unquoted form is a config rule; `published-text` carries the destination guard; the owner list is read from a file spec a set may ship, and `foreign_hosts` extends a built-in list; `hooks --install --adopt` takes over a hand-written pre-push delegate, `hooks --identity` reports one that drifted, and a probe can push an empty range; and the message unicode guard takes an allow list that cannot admit an invisible. Two of those change what a policy file may say (`[override]` and `private_owners_file`) and one adds a set, so the released 1.18.0 shim fails closed on this repository's own policy until this release is the one on PATH.
|
Warning Review limit reachedNext included review available in 21 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #208 +/- ##
=======================================
Coverage 93.76% 93.76%
=======================================
Files 44 44
Lines 18242 18242
=======================================
Hits 17104 17104
Misses 1138 1138 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ten changes since 1.18.0, every one answering a consumer sweep. The shim
steps past a PATH shim of somebody else's instead of looping through it, a
literal source is asked once per process, and a bare issue number after a
list separator is a tracker reference. An
[override.<id>]table narrowswhere an inherited rule reads without restating it; tracker references in
code are the
code-residueset and a documentation line is reported underone id; a committed credential in source is a quoted literal and the
unquoted form is a config rule;
published-textcarries the destinationguard; the owner list is read from a file spec a set may ship, and
foreign_hostsextends a built-in list;hooks --install --adopttakesover a hand-written pre-push delegate,
hooks --identityreports one thatdrifted, and a probe can push an empty range; and the message unicode
guard takes an allow list that cannot admit an invisible.
Two of those change what a policy file may say (
[override]andprivate_owners_file) and one adds a set, so the released 1.18.0 shimfails closed on this repository's own policy until this release is the
one on PATH.