Uh oh!
There was an error while loading. Please reload this page.
Added Tests for use in discoverring issue with escape characters - #348
Closed
mcgear wants to merge 5 commits into
Closed
Added Tests for use in discoverring issue with escape characters#348mcgear wants to merge 5 commits into
mcgear wants to merge 5 commits into
Conversation
mcgear
commented
Jun 8, 2020
Author
I was able to get some time to take a look at the issue, and i believe that the simple two liner that i added allows for proper node management in a case where multiple \ is necessary to remain in the template. All original Unit Tests are passing as well as the new ones for this specific case. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As i was testing some things we are trying to do with Handlebars.net in some json files and ran into an issue, when compiling a template with, the use of '\'. I added two unit tests, one to show Json serialization working without escape sequences, the other to demonstrate it broken.
The issue does not seem to happen against other escape sequences like " as you'll see in the unit test.