Skip to content

Add optional 3rd argument to lookup helper - #542

Merged
oformaniuk merged 5 commits into
masterfrom
stef-lookup
Feb 23, 2023
Merged

Add optional 3rd argument to lookup helper#542
oformaniuk merged 5 commits into
masterfrom
stef-lookup

Conversation

@StefH

@StefHStefH commented Feb 21, 2023

Copy link
Copy Markdown
Collaborator

No description provided.

@StefHStefH mentioned this pull request Feb 21, 2023
Merged
oformaniuk
oformaniuk requested changes Feb 22, 2023
View reviewed changes
Comment threadsource/Handlebars/Helpers/LookupReturnHelperDescriptor.cs Outdated
Comment threadsource/Handlebars.Test/BasicIntegrationTests.cs
@sonarqubecloud

sonarqubecloudBot commented Feb 22, 2023•
edited
Loading

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed! Quality Gate passed

BugA0 Bugs
VulnerabilityA0 Vulnerabilities
Security HotspotA0 Security Hotspots
Code SmellA0 Code Smells

100.0%100.0% Coverage
0.0%0.0% Duplication

@oformaniuk
oformaniuk merged commit 50614fd into masterFeb 23, 2023
@oformaniuk
oformaniuk deleted the stef-lookup branch February 23, 2023 20:14
@StefH

StefH commented Feb 23, 2023

Copy link
Copy Markdown
CollaboratorAuthor

@zjklee
Thanks for merging.
(BTW I always use Squash-Commit when merging a PR to master, else you see all the individual commits which do not add that much value and the branch tree-view looks a bit cleaner)

Any idea when a new NuGet will be released?

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oformaniukoformaniukoformaniuk approved these changes

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@StefH@oformaniuk