Skip to content

Add EmbedUntrackedSources - #570

Merged
oformaniuk merged 3 commits into
Handlebars-Net:masterfrom
lahma:license-expression
Apr 1, 2024
Merged

Add EmbedUntrackedSources#570
oformaniuk merged 3 commits into
Handlebars-Net:masterfrom
lahma:license-expression

Conversation

@lahma

@lahmalahma commented Feb 16, 2024

Copy link
Copy Markdown
Contributor

I would also suggest changing to use newer GH Actions images for building so that other warnings would go away (old SDK in use). Maybe another modernization step could be removing old unsupported full framework targets and only support oldest supported net462. Adding net6.0 target would allow one target without dependency on Microsoft.Csharp.

@StefH

Copy link
Copy Markdown
Collaborator

@lahma
Thank you.
But actually the "license expression" is already fixed by me (#564)

About EmbedUntrackedSources --> that's ok.

And thanks about the hint for "newer GH Actions images", I'll take a look.

@lahma

Copy link
Copy Markdown
ContributorAuthor

Ah, great minds think a like I guess 😄 I've updated the PR title and contents to only contain EmbedUntrackedSources set to true

@lahmalahma changed the title Add PackageLicenseExpressionAdd EmbedUntrackedSourcesFeb 16, 2024
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate PassedQuality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sonarqubecloud

Copy link
Copy Markdown

Quality Gate PassedQuality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@oformaniuk
oformaniuk merged commit bed0c0e into Handlebars-Net:masterApr 1, 2024
@lahma
lahma deleted the license-expression branch April 1, 2024 06:25
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@lahma@StefH@oformaniuk