Skip to content

Update of TFM & dependency optimisation - #578

Merged
oformaniuk merged 4 commits into
Handlebars-Net:masterfrom
thompson-tomo:chore/#573_AddAdditionalTFM
Apr 2, 2024
Merged

Update of TFM & dependency optimisation#578
oformaniuk merged 4 commits into
Handlebars-Net:masterfrom
thompson-tomo:chore/#573_AddAdditionalTFM

Conversation

@thompson-tomo

@thompson-tomothompson-tomo commented Apr 1, 2024

Copy link
Copy Markdown
Contributor

By adjusting the TFM'S we have been able to produce a package with no dependencies on the latest frameworks hence an optimised dependency graph.

The following frameworks have been added:

  • Net 6

The following frameworks even though requested was not added:

  • Net 5

The following frameworks were removed:

  • Net 4.5.2
  • Net 4.6

Closes: #573
Closes: #415

@oformaniukoformaniuk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider dropping net5 as it is not supported anymore and adding net8.

@thompson-tomo

thompson-tomo commented Apr 2, 2024

Copy link
Copy Markdown
ContributorAuthor

I don't see a benefit in adding dotnet 8 as the dotnet 6 compilation will be used. Will remove net 5.

Thoughts on also dropping net 452, net 46 as it is the same as the net 451 compilation.

@thompson-tomothompson-tomo changed the title Add in Net 5 & 6Update of TFM & dependency optimisationApr 2, 2024
@thompson-tomo
thompson-tomoforce-pushed the chore/#573_AddAdditionalTFM branch from 6c9f3a4 to 6465f65CompareApril 2, 2024 03:59
@oformaniuk

Copy link
Copy Markdown
Member

Thoughts on also dropping net 452, net 46 as it is the same as the net 451 compilation.

Yes, this is a good idea to optimize monikers 👍

@sonarqubecloud

Copy link
Copy Markdown

@thompson-tomo

Copy link
Copy Markdown
ContributorAuthor

@oformaniuk i have just gone & dropped those 2 TFM's from the package.

@oformaniuk
oformaniuk merged commit 837fc18 into Handlebars-Net:masterApr 2, 2024
@thompson-tomo
thompson-tomo deleted the chore/#573_AddAdditionalTFM branch April 2, 2024 18:25
@oformaniuk

Copy link
Copy Markdown
Member

@thompson-tomo

thompson-tomo commented Apr 3, 2024

Copy link
Copy Markdown
ContributorAuthor

@oformaniuk should be Fixed in #579

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve dependency graph by adding TFM Any porting available for .net core 5.0

2 participants

@thompson-tomo@oformaniuk