Uh oh!
There was an error while loading. Please reload this page.
Conversation
Uh oh!
There was an error while loading. Please reload this page.
nabobalis
commented
Oct 17, 2022
I would like to get a 1.0.1 out of the door with this PR. |
| if filename.exists() and not overwrite: | ||
| raise FileExistsError(f"{filename} already exists. Use overwrite=True to overwrite.") | ||
| filename.write_bytes(data) | ||
| return filename |
There was a problem hiding this comment.
Was there a reason to not do this?
It is quite useful to get the return and so I can pass that filepath into another function.
There was a problem hiding this comment.
Actually, I don't recall. It is better now.
save_file now cleans the filename, expands user and returns the full file pathcodecov-commenter
commented
Oct 17, 2022
Codecov ReportBase: 99.29% // Head: 99.30% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@## main #84 +/- ##
=======================================
Coverage 99.29% 99.30% =======================================
Files 25 25 Lines 711 716 +5 =======================================
+ Hits 706 711 +5
Misses 5 5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Uh oh!
There was an error while loading. Please reload this page.
Fixes#83
Cleans filename, expands users and returns the filename now.
We also forgot to delete the old changelog file and point users to where the "changelogs" are kept.