Skip to content

add basic galvo support - #63

Merged
Cody-G merged 2 commits into
masterfrom
cjg/galvos
Dec 7, 2017
Merged

Cody-G merged 2 commits into
masterfrom
cjg/galvos

Conversation

@Cody-G

@Cody-G Cody-G commented Dec 7, 2017

Copy link
Copy Markdown
Contributor

fixes #47 and #59

@codecov-io

codecov-io commented Dec 7, 2017

Copy link
Copy Markdown

Codecov Report

Merging #63 into master will increase coverage by 0.14%.
The diff coverage is 86.36%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #63      +/-   ##
==========================================
+ Coverage    85.2%   85.35%   +0.14%     
==========================================
  Files          12       12              
  Lines        1129     1147      +18     
==========================================
+ Hits          962      979      +17     
- Misses        167      168       +1
Impacted Files Coverage Δ
src/hardware_templates.jl 90.74% <100%> (+2.1%) ⬆️
src/metadata_constants.jl 85% <100%> (+1.66%) ⬆️
src/convenience.jl 75% <70%> (+0.8%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 775753a...467af2d. Read the comment docs.

@Cody-G

Cody-G commented Dec 7, 2017

Copy link
Copy Markdown
Contributor Author

Linux and Windows builds pass, Mac build is slowwww so I'm merging

@Cody-G
Cody-G merged commit c954c2d into master Dec 7, 2017
@Cody-G
Cody-G deleted the cjg/galvos branch December 7, 2017 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support galvo control and sensing on OCPI2

2 participants