Uh oh!
There was an error while loading. Please reload this page.
add warnings when datetime-related filters called with null arguments - #1064
Merged
boulter merged 2 commits intoMay 1, 2023
Merged
Conversation
boulter
commented
May 1, 2023
| @Before | ||
| public void setup() { | ||
| jinjava.getGlobalContext().registerClasses(EscapeJsFilter.class); |
ContributorAuthor
There was a problem hiding this comment.
seems like this was copied from some other test
jasmith-hs
approved these changes
May 1, 2023
jasmith-hs
left a comment
Contributor
There was a problem hiding this comment.
Want to add a test that the warning gets added?
boulter
commented
May 1, 2023
ContributorAuthor
Oh weird, I had one. Where did it go? |
boulter
commented
May 1, 2023
ContributorAuthor
jasmith-hs
commented
May 1, 2023
Contributor
Sneaky, I didn't see it! |
boulter
deleted the
jboulter-add-warnings-when-datetimefilters-called-with-null-arguments
branch
May 1, 2023 21:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the future we may change this behavior so null args do not default to the current time. I suspect many users didn't know this was happening since there was no warning.