Uh oh!
There was an error while loading. Please reload this page.
Upgrade jackson and serailize with single quote char - #910
Merged
Conversation
jasmith-hs
marked this pull request as draft
September 9, 2022 18:14
| .replaceAll("(?<!\\\\)(\\\\\\\\)*(?:\")", "$1'"); | ||
| if (!result.contains("{{")) { | ||
| return String.join("} ", result.split("}(?=})")); | ||
| if (string.contains("}}") && !string.contains("{{")) { |
Contributor
There was a problem hiding this comment.
there are config values for these
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Speed up serialization by not needing to do a regex replace on double quotes. Instead in jackson 2.10, they introduced the ability to specify the quote character. If we set the quote character to be a single quote rather than a double quote, then we don't have to use regex to replace the double quotes later.