Uh oh!
There was an error while loading. Please reload this page.
ws_shard: make disable_memory_map a direct kwarg with auto-fallback o… - #71
Draft
tig888 wants to merge 1 commit into
Draft
ws_shard: make disable_memory_map a direct kwarg with auto-fallback o…#71tig888 wants to merge 1 commit into
tig888 wants to merge 1 commit into
Conversation
rashishhume
approved these changes
May 13, 2026
rashishhume
marked this pull request as draft
May 13, 2026 18:43
rashishhume
commented
May 13, 2026
Collaborator
May not want to merge this: https://hume-hq.slack.com/archives/C09LZE6PQ4A/p1778697747822349?thread_ts=1778695152.745449&cid=C09LZE6PQ4A |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move disable_memory_map from a WSDataset-level flag to a WSShard kwarg (default
False), and auto-fall back to pa.OSFile when pa.memory_map raises OSError (e.g.
on NFS / container filesystems that don't support mmap). WSDataset no longer
carries the flag — the common case is now zero-config, and direct WSShard users
no longer need a stub dataset to satisfy dataset.disable_memory_map.