Update 1.0.0 (massive rewrite) - #106
Conversation
write more tests
plotters example
Fix references to renamed account.
Add indicatif progress bars for examples and increase generation count.
Prevent duplicated neuron inputs
create custom activations example
Co-authored-by: HyperCodec <72839119+HyperCodec@users.noreply.github.com>
The original remove_cycles_dfs used a `prev: Option<NeuronLocation>` parameter to identify the back-edge when a cycle was detected. Due to HashMap iteration non-determinism, `prev` could hold the wrong value (an ancestor instead of the immediate parent), causing `self[prev].outputs.contains_key(¤t)` to fail silently and leaving cycles in the network. Fix: replace `prev` with an explicit `path: &mut Vec<NeuronLocation>` stack. `path.last()` is always the correct immediate predecessor of `current` in the DFS call stack, regardless of HashMap iteration order. Also remove all temporary debug assertions added during investigation. Co-authored-by: HyperCodec <72839119+HyperCodec@users.noreply.github.com>
Fix remove_cycles_dfs missing cycles due to wrong back-edge parent
HyperCodec
commented
Feb 23, 2026
now that the random catastrophic bug is gone, I just need to finish fixing |
…er the actual update is out)
HyperCodec
commented
Feb 23, 2026
gonna do a final AI review before I merge |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 16 out of 18 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 16 out of 18 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Uh oh!
There was an error while loading. Please reload this page.
No description provided.