Uh oh!
There was an error while loading. Please reload this page.
Refractor/messaging - #2938
Conversation
2361652 to
dc5c948Compare
frjo
left a comment
There was a problem hiding this comment.
Really liking these changes. Will make it easier and clearer to add new notification adapters.
Some tests are failing, will wait for the fix to them before deploying to test.
theskumar
commented
Aug 1, 2022
Will look into the test. |
e583c21 to
c181119CompareCodecov Report
@@ Coverage Diff @@## maintenance/theskumar/update-wagtail-3 #2938 +/- ##
==========================================================================
+ Coverage 81.93% 81.96% +0.02%
==========================================================================
Files 697 704 +7 Lines 24914 24952 +38 ==========================================================================
+ Hits 20414 20452 +38
Misses 4500 4500
Continue to review full report at Codecov.
|
theskumar
commented
Aug 2, 2022
@frjo The tests are passing now, this will merge to |
frjo
commented
Aug 2, 2022
Deploying this to test now. |
Related to #2882
The
messaging.pyhas quite a lot of code with multiple concerns, which can be easily divided into individual independent modules.This refractor puts different messaging adapters into it's own modules for better maintainability and readability