Skip to content

Broken formatting - #189

Merged
samtingleff merged 5 commits into
IABTechLab:masterfrom
rusel1989:cpex-2687-broken-formatting
Mar 11, 2019
Merged

Broken formatting#189
samtingleff merged 5 commits into
IABTechLab:masterfrom
rusel1989:cpex-2687-broken-formatting

Conversation

@rusel1989

Copy link
Copy Markdown
Contributor

closes#164

@rusel1989rusel1989 changed the title Cpex 2687 broken formattingBroken formattingNov 22, 2018
@shackijj

shackijj commented Feb 14, 2019

Copy link
Copy Markdown
Collaborator

Was the problem discussed in #164 specific for a certain website? I'm asking because I can't reproduce it locally.

Overall, it seems that these changes could help in some cases when a websites' styles conflict with CMP's styles. I created #195 because there are other problems with the styles.

Comment threadsrc/components/popup/intro/intro.less Outdated
@lukascpex

Copy link
Copy Markdown

Hi,
regarding your question about the #164 - yes, the concerned sites were:
www.orbion.cz
www.ahaonline.cz
www.maminka.cz

@rusel1989

Copy link
Copy Markdown
ContributorAuthor

@samtingleff can we merge this please ?

@samtingleff
samtingleff merged commit c5d4d34 into IABTechLab:masterMar 11, 2019
samtingleff added a commit that referenced this pull request Mar 11, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CMP formatting displayed differently on various websites

4 participants

@rusel1989@shackijj@lukascpex@samtingleff