Uh oh!
There was an error while loading. Please reload this page.
Add Prebid error diagnostics - #893
Conversation
1f2946f to
62a2dd0CompareChristianPavilonis
commented
Jul 14, 2026
aram356
left a comment
There was a problem hiding this comment.
Summary
The diagnostics are carefully debug-gated, sanitized, bounded, and correlated with escaped auction IDs. One correctness gap still allows oversized non-2xx bodies to bypass the new HTTP-status classification, so changes are requested.
Blocking
🔧 wrench
- Preserve HTTP classification for oversized error bodies (
crates/trusted-server-core/src/integrations/prebid.rs:1977): body collection can fail before the known non-2xx status is converted into provider metadata.
Non-blocking
🏕 camp site
- Add a public
/auctionresponse-shape regression (crates/trusted-server-core/src/integrations/prebid.rs:5135): exercise the security contract through final response serialization.
CI Status
- GitHub integration artifact preparation: PASS
- GitHub integration tests: PASS
- GitHub Fastly EC lifecycle tests: PASS
- GitHub browser integration tests: PASS
- Targeted native Prebid tests: PASS (163 tests)
- Axum tests: PASS (12 tests)
- fmt: PASS
- Local Fastly runtime: BLOCKED by unavailable macOS certificate keychain after successful compilation
- Local clippy-fastly: BLOCKED by local build-tool invocation error (
Unrecognized option: 'p')
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
aram356
left a comment
There was a problem hiding this comment.
Summary
The follow-up commit resolves the prior blocking issue: non-2xx HTTP classification now survives oversized or unreadable response bodies, with one-shot and streaming regressions. The public /auction response also has explicit debug-gating, normalization, and truncation coverage. No additional findings remain.
CI Status
- GitHub integration artifact preparation: PASS
- GitHub integration tests: PASS
- GitHub Fastly EC lifecycle tests: PASS
- GitHub browser integration tests: PASS
- Targeted native Prebid tests: PASS (166 tests)
- fmt: PASS
- Fastly
wasm32-wasip1compilation: PASS
aram356
commented
Jul 16, 2026
@ChristianPavilonis please resolve conflicts |
c3143ab to
4ca09faComparePrebid non-2xx responses were reduced to bare provider errors, making intermittent failures difficult to diagnose. Surface safe HTTP metadata and bounded debug details while correlating server logs with the auction ID.
4ca09fa to
7af7598Compare
Summary
Changes
crates/trusted-server-core/src/integrations/prebid.rsdocs/guide/integrations/prebid.mdCloses
Closes#909.
Test plan
cargo test-fastly && cargo test-axumcargo clippy-fastly && cargo clippy-axumcargo fmt --all -- --checkcd crates/trusted-server-js/lib && npx vitest run(JS unchanged)cd crates/trusted-server-js/lib && npm run format(JS unchanged)cd docs && npm run formatcargo build --package trusted-server-adapter-fastly --release --target wasm32-wasip1fastly compute servecargo test-cloudflare,cargo test-spin, Cloudflare/Spin native and WASM clippy aliases, and integration parity tests.Checklist
unwrap()in production code — useexpect("should ...")logmacros (notprintln!), perCLAUDE.md