Uh oh!
There was an error while loading. Please reload this page.
test: Allow user to specify which transport to use - #157
Merged
Conversation
kadler
reviewed
Mar 18, 2020
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
abmusse
commented
Mar 20, 2020
MemberAuthor
Needed to resolve these conflicts ran |
kadler
reviewed
Mar 24, 2020
Uh oh!
There was an error while loading. Please reload this page.
| transportOptions: { | ||
| database: process.env.TKDB || '*LOCAL', | ||
| username: process.env.TKUSER || '', | ||
| password: process.env.TKPASS || '', |
Member
There was a problem hiding this comment.
Why do we have a separate password and passphrase?
MemberAuthor
There was a problem hiding this comment.
passphrase is used by the ssh transport to decrypt the private key. Its provided if the user's private key requires a passphrase.
Member
There was a problem hiding this comment.
Oh, right. Might be good to have a comment in there.
Uh oh!
There was an error while loading. Please reload this page.
abmusse
commented
Mar 27, 2020
MemberAuthor
Will need to fixup conflicts again. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently every transport is used to run each functional test.
This PR refactors to use only one transport per test case.
Also allows user to export
TKTRANSPORTenv variable to specify which transport to use.Resolves#153