Uh oh!
There was an error while loading. Please reload this page.
docs: Add migration guide - #209
Conversation
kadler
left a comment
There was a problem hiding this comment.
Good first pass. Lots of good info here. In addition to the specific comments, all the "removed at a later time" should be "removed in the next major version".
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
abmusse
commented
Apr 6, 2020
I have added some updates, please re-review. |
kadler
commented
Apr 6, 2020
Let's land this after #173 is done. |
kadler
commented
Apr 22, 2020
Now that we have sphinx set up, @abmusse can you focus on getting this setup within sphinx. I think we should have a migration guide section in the nav bar and hook it in there. Also would be good to link to it from the main intro, adding some text there. |
I had issues getting the emoji I ended up copying UTF-8 Unicode Character 🚨 and pasting it into the migration guide. Better but does not have the styling. |
kadler
commented
Apr 22, 2020
If we convert it to rst, we can use admonitions. Not sure if they are supported by mkdocs. |
kadler
commented
Apr 22, 2020
Yeah converting the migration guide to |
abmusse
commented
Apr 23, 2020
@kadler I've converted the migration guide from markdown to rst |
abmusse
commented
Apr 24, 2020
@kadler This is ready for re-review |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
| Migrating from ``iConn.run()`` to ``Connection.run()`` | ||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ |
There was a problem hiding this comment.
This section is way more important to highlight than the prior one. You should be able to figure out how to connect using Connection from the docs, however you may not realize that iConn -> Connection implies a change in behavior of the callbacks. I think we definitely need some WARNING messages above to point the user at this section and mention returnError.
Something like:
"Beware that the Connection and iConn classes differ in how they call the callbacks passed to their run methods. You cannot simply replace iConn with Connection without adjusting your callbacks. See here for more info on how to do that.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.



Resolves#143